Commits

Author Commit Message Labels Comments Date
minux
all: fix the the typos Fixes issue 4420. R=golang-dev, rsc, remyoudompheng CC=golang-dev http://codereview.appspot.com/6854080
Brad Fitzpatrick
A+C: Add Vladimir Nikishenko (Individual CLA) R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6845073
Joel Sing
runtime: update openbsd runtime to use new tfork syscall Update OpenBSD runtime to use the new version of the sys___tfork syscall and switch TLS initialisation from sys_arch to sys___set_tcb (note that both of these syscalls are available in OpenBSD 5.2). R=golang-dev, minux.ma CC=golang-dev http://codereview.appspot.com/6843058
Rémy Oudompheng
cmd/8g: fix erroneous LEAL nil. Fixes issue 4399. R=golang-dev, nigeltao CC=golang-dev http://codereview.appspot.com/6845053
Dave Cheney
net: remove another unguarded sysfile == nil check Putting aside the unguarded access to fd.sysfile, the condition will never be true as fd.incref above handles the closed condition. R=mikioh.mikioh, dvyukov CC=golang-dev http://codereview.appspot.com/6845062
minux
net/http, net/http/httputil: fix TestChunkReaderAllocs failure when GOMAXPROCS > 1 R=fullung, bradfitz, dave CC=golang-dev http://codereview.appspot.com/6846081
Ian Lance Taylor
exp/types: don't test importing types if using gccgo The exp/types packages does not support the gccgo export data format. At some point it should, but not yet. R=gri, bradfitz, r, iant, dsymonds CC=golang-dev http://codereview.appspot.com/6854068
brainman
net/http/cgi: another attempt to fix windows tests Also enables TestDirWindows test on windows. Fixes Issue 4401. R=golang-dev, bradfitz CC=golang-dev, krautz http://codereview.appspot.com/6847072
Brad Fitzpatrick
net/http: remove more garbage from chunk reading Noticed this while closing tabs. Yesterday I thought I could ignore this garbage and hope that a fix for issue 2205 handled it, but I just realized that's the opposite case, string->[]byte, whereas this is []byte->string. I'm having a hard time convincing myself that an Issue 2205-style fix with static analysis and faking a string header would be safe in all cases without violating the memory mod…
Brad Fitzpatrick
mime/multipart: transparently decode quoted-printable transfer encoding Fixes issue 4411 R=dsymonds CC=gobot, golang-dev http://codereview.appspot.com/6854067
Brad Fitzpatrick
cmd/api: speed up API check by 2x, caching parser.ParseFile calls Saves 5 seconds on my machine. If Issue 4380 is fixed this clone can be removed. Update issue 4380 R=golang-dev, remyoudompheng, minux.ma, gri CC=golang-dev http://codereview.appspot.com/6845058
Robert Griesemer
go/printer: simply ignore filename changes in position information There's no good reason to make any printer state adjustments simply because the file name in node position information has changed. Eliminate the relevant code. R=r CC=golang-dev http://codereview.appspot.com/6856054
Brad Fitzpatrick
doc/articles/wiki: fix racy test R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6853069
Brad Fitzpatrick
net/http/cgi: more windows perl test work Don't rely on finding cmd.exe in a particular spot. Fixes issue 4401 R=golang-dev, krautz CC=golang-dev http://codereview.appspot.com/6842066
Christian Himpel
runtime: gdb support: use parse_and_eval to get the goroutine id This enables to loop over some goroutines, e.g. to print the backtrace of goroutines 1 to 9: set $i = 1 while $i < 10 printf "backtrace of goroutine %d:\n", $i goroutine $i++ bt end R=lvd, lvd CC=golang-dev http://codereview.appspot.com/6843071 Committer: Ian Lance Taylor <iant@golang.org>
Robert Griesemer
cmd/gc: complain about invalid whitespace chars Fixes issue 4405. R=rsc, bradfitz CC=golang-dev http://codereview.appspot.com/6855060
Brad Fitzpatrick
net/http/cgi: make test more robust for Windows perl Update issue 4401 R=golang-dev, mattn.jp CC=golang-dev http://codereview.appspot.com/6853067
Dave Cheney
net: fix data race on fd.sysfd Fixes issue 4369. Remove the check for fd.sysfd < 0, the first line of fd.accept() tests if the fd is open correctly and will handle the fd being closed during accept. R=dvyukov, bradfitz CC=golang-dev http://codereview.appspot.com/6843076
Dave Cheney
net: remove unused nil check This is part 1 of a series of proposals to fix issue 4369. In resolving issue 3507 it was decided not to nil out the inner conn.fd field to avoid a race. This implies the checks for fd == nil inside incref/decref are never true. Removing this logic removes one source of errClosing error values, which affects issue 4373 and moves towards bradfitz's request that fd.accept() return io.EOF when clos…
Dave Cheney
runtime/cgo: enable warnings and treat as errors Enable warnings as errors during the cgo portion of runtime/cgo. iant requested that the list of flags match cmd/dist/build.c, but I would like to avoid the set of disabled warnings if possible. ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion requires: 6843061 R=minux.ma, iant CC=golang-dev http://codereview.appspot.com/6852055
Robert Griesemer
spec: fix constant expression example Fixes issue 4400. R=r, mirtchovski CC=golang-dev http://codereview.appspot.com/6782084
minux
runtime: don't assume AT_RANDOM provide 4-byte aligned ptr R=dave, remyoudompheng CC=golang-dev http://codereview.appspot.com/6854056
Robert Griesemer
go/doc: fix identifier blank import handling for examples Replacement CL for 6813061; thanks to minux for prototyping. Fixes issue 4300. R=minux.ma CC=golang-dev http://codereview.appspot.com/6782082
minux
lib/godoc/codewalk.html: remove duplicate jquery inclusion now we load jquery in its parent--godoc.html. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6814112
minux
crypto/md5: speed up aligned writes and test/bench unaligned writes Write() can safely use uint32 loads when input is aligned. Also add test and benchmarks for unaligned writes. Benchmark result obtained by Dave Cheney on ARMv5TE @ 1.2GHz: benchmark old ns/op new ns/op delta BenchmarkHash8Bytes 4104 3417 -16.74% BenchmarkHash1K 22061 11208 -49.20% BenchmarkHash8K 146630 65148 -55.57% BenchmarkHash8BytesUnaligned 4128 3436 -16.76% BenchmarkHash1KUna…
minux
runtime/cgo: fix compilation on Windows with CFLAGS -Wall -Werror also fix one out-of-date comment in cmd/ld/pe.c as well. R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/6843061
Dave Cheney
archive/zip: handle extra data headers with no body Fixes issue 4393. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6854058
Robin Eklind
archive/zip, crypto/tls, net/http: Fix print format errors. All of the errors were located using "go vet ./..." in "src/pkg". R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6856056 Committer: Ian Lance Taylor <iant@golang.org>
Brad Fitzpatrick
net/http: reduce allocations in chunk reading & writing R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6847063
Robert Griesemer
go/printer: leave indentation alone when printing nodes from different files ASTs may be created by various tools and built from nodes of different files. An incorrectly constructed AST will likely not print at all, but a (structurally) correct AST with bad position information should still print structurally correct. One heuristic used was to reset indentation when the filename in the position information of nodes changed. However, this can lead to wrong indentation for …
  1. Prev
  2. Next