Commits

Author Commit Message Labels Comments Date
Dave Cheney
cmd/dist: detect debian/kFreeBSD
Luit van Drongelen
encoding/gob: Fix typo in doc.go Exactly how I find minute details like this is beyond me. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/6842125 Committer: Brad Fitzpatrick <bradfitz@golang.org>
Johan Euphrosine
math/rand: remove noop iteration in Perm The first iteration always do `m[0], m[0] = m[0], m[0]`, because `rand.Intn(1)` is 0. fun note: IIRC in TAOCP version of this algorithm, `i` goes backward (n-1->1), meaning that the "already" shuffled part of the array is never altered betweens iterations, while in the current implementation the "not-yet" shuffled part of the array is conserved between iterations. R=golang-dev CC=golang-dev http…
Brad Fitzpatrick
crypto/tls: fix loading keys labeled just "PRIVATE KEY" Worked in Go 1, broken in f440e65f93fe. Fixes issue 4477 R=golang-dev, agl CC=golang-dev https://codereview.appspot.com/6865043
Rémy Oudompheng
net: remove unnecessary Close contention. Contention profile in BenchmarkTCPOneShot (Core 2 Quad): Before Total: 80.285 seconds 44.743 55.7% 55.7% 44.743 55.7% runtime.chanrecv1 31.995 39.9% 95.6% 31.995 39.9% sync.(*Mutex).Lock 3.547 4.4% 100.0% 3.547 4.4% runtime.chansend1 After Total: 48.341 seconds 45.810 94.8% 94.8% 45.810 94.8% runtime.chanrecv1 2.530 5.2% 100.0% 2.530 5.2% runtime.chansend1 0.001 …
Mikio Hara
net: allow "" as a hint wildcard to Resolve{IP,UDP,TCP}Addr Also fixes comments on ResolveIPAddr. Fixes issue 4476. R=bradfitz, golang-dev CC=golang-dev https://codereview.appspot.com/6854129
Ian Lance Taylor
test: add a test that caused gccgo to crash R=golang-dev CC=golang-dev https://codereview.appspot.com/6849129
Anthony Martin
net: update docs and sync API for Plan 9 R=golang-dev, dave, mikioh.mikioh, bradfitz, rsc CC=golang-dev https://codereview.appspot.com/6674043
minux
cmd/godoc: fix `godoc net/http` on windows `godoc net/http` used to complain "/target contains more than one package: http, main" R=golang-dev, bradfitz, rsc CC=golang-dev https://codereview.appspot.com/6852100
minux
all: set GOMAXPROCS to 1 when counting mallocs also fix an annoying test that relies on $GOROOT be set. Fixes issue 3690. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/6844086
Dave Cheney
undo CL 6855110 / 869253ef7009 64bit atomics are broken on 32bit systems. This is issue 599. linux/arm builders all broke with this change, I am concerned that the other 32bit builders are silently impacted. ««« original CL description net: fix data races on deadline vars Fixes issue 4434. R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman CC=golang-dev https://codereview.appspot.com/6855110 »»» R=rsc, mikioh.mikioh, dvyuko…
Dave Cheney
net: fix data races on deadline vars Fixes issue 4434. R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman CC=golang-dev https://codereview.appspot.com/6855110
Dmitriy Vyukov
runtime: better stack traces in race reports When a race happens inside of runtime (chan, slice, etc), currently reports contain only user file:line. If the line contains a complex expression, it's difficult to figure out where the race exactly. This change adds one more top frame with exact runtime function (e.g. runtime.chansend, runtime.mapaccess). R=golang-dev CC=golang-dev https://codereview.appspot.com/6851125
Dmitriy Vyukov
cmd/gc: racewalk: collect stack traces in sync and sync/atomic W/o this change stack traces do not show from where sync.Once() or atomic.XXX was called. This change add funcenter/exit instrumentation to sync/sync.atomic packages. R=golang-dev CC=golang-dev https://codereview.appspot.com/6854112
brainman
os: check only user attributes in TestStatDirModeExec Some have their system setup in a particular way, see http://golang.org/issue/4444#c3. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/6851129
Brad Fitzpatrick
net/http: don't send chunked encoding on 204 responses RFC 2616: "The 204 response MUST NOT include a message-body, and thus is always terminated by the first empty line after the header fields." Previously we'd trigger chunked encoding by default on responses, and then when finishing the request we'd write the chunk trailers, which counted as a message-body. Fixes issue 4454 R=golang-dev CC=golang-dev https://codereview.appspot.com/6782139
Robert Griesemer
go spec: receiver, parameter, and result names must always be unique Fixes issue 4450. R=rsc, iant CC=golang-dev https://codereview.appspot.com/6845104
Russ Cox
net: add test case for SplitHostPort with zone R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/6854119
Robert Griesemer
spec: clarify use of built-ins in go/defer statements 1) Built-ins are restricted like for expression statements. This documents the status quo. 2) Calls cannot be parenthesized. The spec is not clear. gccgo permits it already, gc doesn't. Be explicit in the spec. Fixes issue 4462. R=rsc, iant, r, ken, lvd CC=golang-dev https://codereview.appspot.com/6861043
Brad Fitzpatrick
codereview: always use HTTPS The new version of rietveld pushed 1.5 hours ago requires HTTPS now, otherwise it issues a 301 to HTTPS which we barfed on. R=golang-dev CC=golang-dev https://codereview.appspot.com/6782135
Robert Griesemer
exp/types: various missing checks for array/slice composite literals - check indices of array/slice composite literals - handle [...]T - also: go/defer statements R=rsc CC=golang-dev http://codereview.appspot.com/6856107
Robert Griesemer
go/parser: permit [...]T where array types are permitted More lenient parsing with better error recovery. It's easier for the type check to pick up the slack. R=iant CC=golang-dev http://codereview.appspot.com/6856108
brainman
os: include 0111 in directory file mode on windows Fixes issue 4444. R=golang-dev, minux.ma, rsc CC=golang-dev http://codereview.appspot.com/6858079
brainman
exp/winfsnotify: fix data race in TestNotifyClose Fixes issue 4342. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6850080
brainman
net/http: fix broken TestIssue4191_InfiniteGetToPutTimeout Test creates 2 tcp connections for put and get. Make sure these are closed properly after test is over, otherwise server hangs waiting for connection to be closed. R=golang-dev, bradfitz, dave CC=golang-dev http://codereview.appspot.com/6842109
Dave Cheney
net: move deadline logic into pollServer Update issue 4434. The proposal attempts to reduce the number of places where fd,{r,w}deadline is checked and updated in preparation for issue 4434. In doing so the deadline logic is simplified by letting the pollster return errTimeout from netFD.Wait{Read,Write} as part of the wakeup logic. The behaviour of setting n = 0 has been restored to match rev 2a55e349097f, which was the previous change…
Mikio Hara
net: fix ResolveIPAddr Fixes misedit in CL 6842053. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6849115
Dave Cheney
net: fix intermittent TestAddFDReturnsError failure A fix similar to CL 6859043 was effective in resolving the intermittent failure. Fixes issue 4423. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6854102
Mikio Hara
net: consoldate literal target address into IP address functions This CL continues with introducing IPv6 scoped addressing capability into the net package. Update issue 4234. R=rsc CC=golang-dev http://codereview.appspot.com/6842053
Rémy Oudompheng
cmd/5g, cmd/8g: fix internal error on 64-bit indices statically bounded Fixes issue 4448. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6855100
  1. Prev
  2. Next