Commits

Author Commit Message Labels Comments Date
Dmitriy Vyukov
race: sync/atomic changes This is a part of a bigger change that adds data race detection feature: http://codereview.appspot.com/6456044 R=rsc, remyoudompheng CC=gobot, golang-dev http://codereview.appspot.com/6536059
Dmitriy Vyukov
race: sync changes This is a part of a bigger change that adds data race detection feature: http://codereview.appspot.com/6456044 R=rsc, minux.ma CC=gobot, golang-dev http://codereview.appspot.com/6529053
Dmitriy Vyukov
race: runtime changes This is a part of a bigger change that adds data race detection feature: http://codereview.appspot.com/6456044 R=rsc CC=gobot, golang-dev http://codereview.appspot.com/6535050
minux
runtime: disable TestParForParallel for now on 32-bit hosts Also add call to GC() to make it easier to re-enable the test. Update issue 4155. When we have precise GC merged, re-enable this test. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6622058
minux
test/run.go: use correct executable filename on Windows, fix build R=golang-dev, daniel.morsing CC=golang-dev http://codereview.appspot.com/6624060
Brad Fitzpatrick
os: make TestMkdirAllWithSymlink more robust Don't assume the test has a clean environment within /tmp. Use an actual new tempdir for its tests. Fixes FreeBSD build failure as seen at: http://build.golang.org/log/396738676356d7fb6bab6eaf1b97cac820f8a90f --- FAIL: TestMkdirAllWithSymlink (0.00 seconds) path_test.go:178: Mkdir /tmp/dir: mkdir /tmp/dir: file exists FAIL FAIL os 1.091s R=golang-dev, minux.ma CC=golang-…
Brad Fitzpatrick
net/http/httptest: mimic the normal HTTP server's ResponseWriter more closely Also adds tests, which didn't exist before. Fixes issue 4188 R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6613062
Rémy Oudompheng
test: use rundir and errorcheckdir for a few more tests. Update issue 4139. R=golang-dev, minux.ma CC=golang-dev http://codereview.appspot.com/6620070
minux
testing: fix extra tabs when t.Log("string") t.Log("line 1\nline 2\nline 3") Old output: === RUN TestLine3 --- PASS: TestLine3 (0.00 seconds) testing_test.go:25: line 1 line 2 line 3 PASS New output: === RUN TestLine3 --- PASS: TestLine3 (0.00 seconds) testing_test.go:24: line 1 line 2 line 3 PASS R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6613069
minux
syscall: fix Statfs and Fstatfs on Linux/ARM R=golang-dev, dave, rsc CC=golang-dev http://codereview.appspot.com/6615055
Rémy Oudompheng
cmd/gc: replace "typechecking loop" by nicer errors in some cases. For issue 3757: BEFORE: test/fixedbugs/bug463.go:12: typechecking loop involving a test/fixedbugs/bug463.go:12 a test/fixedbugs/bug463.go:12 <node DCLCONST> AFTER: test/fixedbugs/bug463.go:12: constant definition loop test/fixedbugs/bug463.go:12: a uses a For issue 3937: BEFORE: test/fixedbugs/bug464.go:12: typechecking loop involving foo test…
Daniel Morsing
cmd/gc: Don't accept qualified names as literal keys Fixes issue 4067. R=golang-dev, minux.ma, dave, rsc CC=golang-dev http://codereview.appspot.com/6622056
Nigel Tao
image/jpeg: move the huffman bit decoder state higher up in the decoder struct, inside the unmappedzero limit, to eliminate some TESTB instructions in the inner decoding loop. benchmark old ns/op new ns/op delta BenchmarkDecode 2943204 2746360 -6.69% R=r, dave CC=golang-dev http://codereview.appspot.com/6625058
minux
cmd/gc: fix output filename generation on Windows R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6610060
Akshat Kumar
cmd/gc: don't dereference a nil Type pointer in widstruct The nil dereference in the next few lines doesn't seem to cause a segmentation fault on Unix, but does seem to halt the Go compiler. The following is a test case: >>> package main func mine(int b) int { return b + 2 } func main() { mine() c = mine() } <<< Without this change only the following is caught: typecheck.go:3: undefined: b typecheck.go:4: undefined: b with…
Daniel Morsing
cmd/gc: Don't export embedded builtins Fixes issue 4124. R=golang-dev, dave, minux.ma, remyoudompheng, rsc CC=golang-dev http://codereview.appspot.com/6543057
Dave Cheney
cmd/5g: avoid temporary in slice bounds check before func addr(s[]int) *int { return &s[2] 10c1c: e28d0008 add r0, sp, #8 10c20: e5901004 ldr r1, [r0, #4] 10c24: e3a02002 mov r2, #2 10c28: e1510002 cmp r1, r2 10c2c: 8a000000 bhi 10c34 <main.addr+0x34> 10c30: eb0035e6 bl 1e3d0 <runtime.panicindex> 10c34: e5…
Nigel Tao
image/jpeg: move the level-shift and clip out of the idct function, to be consistent with the fdct function, and to ease any future idct rewrites in assembly. The BenchmarkIDCT delta is obviously just an accounting change and not a real saving, but it does give an indication of what proportion of time was spent in the actual IDCT and what proportion was in shift and clip. The idct time taken is now comparable to fdct. The BenchmarkFDCT delta is an estimate of benchmark noise. benchmark old ns/op new ns/op delta BenchmarkFDCT …
Nigel Tao
image/jpeg: clean up BenchmarkDecode and BenchmarkEncode to not refer to opacity. Those references were copy/pasted from the image/png encoding benchmarks, which cares whether or not the source image is opaque, but the JPEG encoder does not care. R=r CC=golang-dev http://codereview.appspot.com/6623052
Robert Hencke
doc/debugging_with_gdb: fix minor typo (space before comma) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6610061 Committer: Rob Pike <r@golang.org>
Nigel Tao
image/jpeg: add DCT tests, do a small optimization (common sub-expression elimination) in idct.go. benchmark old ns/op new ns/op delta BenchmarkIDCT 5649 5610 -0.69% BenchmarkDecodeRGBOpaque 2948607 2941051 -0.26% The "type block" declaration moved so that idct.go is compilable as a stand-alone file: "go tool 6g -S idct.go" works. R=r CC=golang-dev http://codereview.appspot.com/6619056
Rémy Oudompheng
cmd/gc: avoid clobbering the AST in cgen_callmeth. It confused the detection of init loops when involving method calls. Fixes issue 3890. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6620067
Rémy Oudompheng
cmd/6g: fix out of registers when chaining integer divisions. Fixes issue 4201. R=golang-dev, rsc CC=golang-dev, remy http://codereview.appspot.com/6622055
Rémy Oudompheng
cmd/gc: make rnd() more 64-bit-friendly. Fixes issue 4200. R=golang-dev, dave, rsc CC=golang-dev http://codereview.appspot.com/6619057
Rob Pike
text/template: fix nil crash on Templates Fixes issue 3872. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6612060
Rob Pike
text/template: add an unexported method to Node Protects the package a little against undesirable clients. R=golang-dev, bradfitz, rsc CC=golang-dev http://codereview.appspot.com/6624054
Dave Cheney
cmd/5g: avoid temporary during constant asop func add() int { var a int a += 10 a += 20 a += 30 a -= 10 a -= 20 a -= 30 return a } before --- prog list "add" --- 0000 (/home/dfc/src/add.go:5) TEXT add+0(SB),$0-4 0001 (/home/dfc/src/add.go:6) MOVW $0,R2 0002 (/home/dfc/src/add.go:7) MOVW $10,R0 0003 (/home/dfc/src/add.go:7) ADD R0,R2,R1 0004 (/home/dfc/src/…
Rémy Oudompheng
runtime: fix a panic when growing zero-width-element slices. Fixes issue 4197. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6611056
Dmitriy Vyukov
pprof: add goroutine blocking profiling The profiler collects goroutine blocking information similar to Google Perf Tools. You may see an example of the profile (converted to svg) attached to http://code.google.com/p/go/issues/detail?id=3946 The public API changes are: +pkg runtime, func BlockProfile([]BlockProfileRecord) (int, bool) +pkg runtime, func SetBlockProfileRate(int) +pkg runtime, method (*BlockProfileRecord) Stack() []uintptr +pkg runtime, type BlockProfileRecord struct +pkg runtime, type BlockProfileRecord struct, Count int64 +pkg runtime, type BlockProfileRecord struct, Cycles int64 +pkg runtime, type BlockProfileRecord struct, embedded StackRecord R=rsc, dave, minux.ma, r CC=gobot, golang-dev, r, remyoudompheng http://codereview.appspot.com/6443115
Daniel Morsing
test: Add rundir, rundircmpout and errorcheckdir commands to testlib and run.go rundir will compile each file in the directory in lexicographic order, link the last file as the main package and run the resulting program. rundircmpout is an related command, that will compare the output of the program to an corresponding .out file errorcheckdir will compile each file in a directory in lexicographic order, running errorcheck on each file as it compiles. All compilations are ass…
  1. Prev
  2. Next