Commits

Author Commit Message Labels Comments Date
Russ Cox
cmd/gc: delete dead code R=ken2 CC=golang-dev http://codereview.appspot.com/6307050
Russ Cox
cmd/gc: do not crash on struct with _ field Fixes issue 3607. R=ken2 CC=golang-dev http://codereview.appspot.com/6296052
Russ Cox
cmd/gc: preserve side effects during inlining of function with _ argument Fixes issue 3593. R=ken2 CC=golang-dev, lvd http://codereview.appspot.com/6305061
Russ Cox
encoding/json: fix panic unmarshaling into non-nil interface value Fixes issue 3614. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6306051
Russ Cox
cmd/gc: mark output of typename as type-checked R=ken2 CC=golang-dev http://codereview.appspot.com/6302051
Nigel Tao
exp/html: when parsing, compare atoms (ints) instead of strings. This is the mechanical part of the 2-part change that started with http://codereview.appspot.com/6305053/ R=rsc CC=andybalholm, golang-dev, r http://codereview.appspot.com/6295055
Nigel Tao
exp/html: make the tokenizer return atoms for tag tokens. This is part 1 of a 2 part changelist. Part 2 contains the mechanical change to parse.go to compare atoms (ints) instead of strings. The overall effect of the two changes are: benchmark old ns/op new ns/op delta BenchmarkParser 4462274 4058254 -9.05% BenchmarkRawLevelTokenizer 913202 912917 -0.03% BenchmarkLowLevelTokenizer 1…
Dave Cheney
test/bench/go1: add go/parser benchmark As discussed in https://groups.google.com/d/msg/golang-dev/Na9XE6mcQyY/zbeBI7R-vnoJ Here is a static copy of the go/parser benchmark. I ended up using fancy encodings because the original parser.go had a number of `s scattered throughout which made it hard to embed the source directly. Curiously on my laptop this benchmark always scores roughly 10% higher than the standalone benchmark. This may…
brainman
runtime: include "typekind.h" to fix windows build R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6305059
Nigel Tao
exp/html/atom: add more atoms. This completely covers the tags used by exp/html's parser. Before: 295 atoms; 1406 string bytes + 2048 tables = 3454 total data BenchmarkLookup 50000 59841 ns/op After: 322 atoms; 1508 string bytes + 2048 tables = 3556 total data BenchmarkLookup 50000 60159 ns/op R=r CC=golang-dev http://codereview.appspot.com/6296045
Andrew Gerrand
misc/dashboard/app: fix build failure notifications The datastore.Query methods once mutated the Query value, but now they return a derivative query, so the Hash= and ParentHash= filters were not being applied. R=golang-dev, bradfitz, dsymonds CC=golang-dev http://codereview.appspot.com/6300058
Fazlul Shahriar
net: pass tests on Plan 9 again R=golang-dev CC=golang-dev http://codereview.appspot.com/6280045 Committer: Russ Cox <rsc@golang.org>
Jan Ziak
runtime: move type kinds into a separate file R=rsc CC=golang-dev http://codereview.appspot.com/6285047 Committer: Russ Cox <rsc@golang.org>
Daniel Morsing
fmt: fix doc typo R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6308046 Committer: Russ Cox <rsc@golang.org>
Russ Cox
A+C: Daniel Morsing (individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6307048
mspace
crypto/rand: enable rand.Reader on plan9 R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6297044 Committer: Russ Cox <rsc@golang.org>
Russ Cox
A+C: Markus Sonderegger (individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6303047
Russ Cox
fmt: fix inadvertent change to %#v The reordering speedup in CL 6245068 changed the semantics of %#v by delaying the clearing of some flags. Restore the old semantics and add a test. Fixes issue 3706. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6302048
minux
net: fix cgoAddrInfoFlags() on FreeBSD CL 6250075 removed AI_MASK mask on all BSD variants, however FreeBSD's AI_MASK does not include AI_V4MAPPED and AI_ALL, and its libc is strict about the ai_flags. This will fix the FreeBSD builder. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6305054
minux
build: restore PATH before "dist banner" Fixes issue 3699. R=golang-dev, r, rsc CC=golang-dev http://codereview.appspot.com/6272048
Joel Sing
runtime: fix tv_sec handling for netbsd/386 On netbsd/386, tv_sec is a 64-bit integer for both timeval and timespec. Fix the time handling code so that it works correctly. R=golang-dev, rsc, m4dh4tt3r CC=golang-dev http://codereview.appspot.com/6256056
Dave Cheney
cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1 This should be the last of them. R=golang-dev, minux.ma, rsc CC=golang-dev http://codereview.appspot.com/6297043
Dave Cheney
test/bench/go1: reduce fasta data size for linux/arm As discussed on golang-dev, reduce the size of the fasta dataset to make it possible to run the go1 benchmarks on small ARM systems. Also, remove the 25m suffix from fasta data and Revcomp. linux/arm: pandaboard OMAP4 BenchmarkBinaryTree17 1 70892426000 ns/op BenchmarkFannkuch11 1 35712066000 ns/op BenchmarkGobDecode 10 137146000 ns/op …
Russ Cox
runtime: use OS X vsyscall for gettimeofday (amd64) Thanks to Dave Cheney for the magic words "comm page". benchmark old ns/op new ns/op delta BenchmarkNow 197 33 -83.05% This should make profiling a little better on OS X. The raw time saved is unlikely to matter: what likely matters more is that it seems like OS X sends profiling signals on the way out of system calls more often than it should; avoiding the system…
Russ Cox
runtime: use OS X vsyscall for gettimeofday (386) amd64 was done in CL 6275056. We don't attempt to handle machines with clock speeds less than 1 GHz. Those will fall back to the system call. benchmark old ns/op new ns/op delta BenchmarkNow 364 38 -89.53% R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6307045
Dave Cheney
runtime: use uintptr for block length in scanblock Using an int64 for a block size doesn't make sense on 32bit platforms but extracts a performance penalty dealing with double word quantities on Arm. linux/arm benchmark old ns/op new ns/op delta BenchmarkGobDecode 155401600 144589300 -6.96% BenchmarkGobEncode 72772220 62460940 -14.17% BenchmarkGzip 5822632 2604797 -55.26% Benchma…
Rémy Oudompheng
cmd/[568]g: correct freeing of allocated Regs. R=golang-dev, rsc CC=golang-dev, remy http://codereview.appspot.com/6281050
Nigel Tao
gc: fix typo. There already is a "Phase 6" a few lines above. R=rsc CC=golang-dev http://codereview.appspot.com/6270054
Rob Pike
net/http/httputil: fix typo in comment. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6272050
Rémy Oudompheng
test: avoid interface conversion in rotate.go It is not necessary for the test to be effective and uses a lot of resources in the compiler. Memory usage is halved and compilation around 8x faster. R=golang-dev, r, rsc, r CC=golang-dev http://codereview.appspot.com/6290044
  1. Prev
  2. Next