Commits

Show all
Author Commit Message Labels Comments Date
Russ Cox
doc/contribute: try to make it clearer that you send a review with hg mail, not hg submit. R=r http://codereview.appspot.com/171046
Tags
weekly.2009-12-09
rogpeppe
added benchmarks to rand_test.go; removed superfluous field name in lockedSource. R=r, rsc http://codereview.appspot.com/170043 Committer: Russ Cox <rsc@golang.org>
Rob Pike
syscalls can return negative i/o counts. fix bugs in ReadAt and WriteAt not to include negative counts in return values. R=rsc CC=golang-dev http://codereview.appspot.com/170044
Russ Cox
doc: split contribute.html into code.html and contribute.html R=r http://codereview.appspot.com/170042
rogpeppe
Make the operations on the global rng thread safe. R=r, rsc CC=golang-dev http://codereview.appspot.com/168041 Committer: Russ Cox <rsc@golang.org>
Charles L. Dorian
Continuation of issue 221 fix. When 8g or 6g or 5g are called with a UTF-8 string, Yconv() converts it into an octal sequence. If the string converted to more than 30 bytes, the str buffer would overflow. For example, 4 Greek runes became 32 bytes, 3 Hiragana runes became 36 bytes, and 2 Gothic runes became 32 bytes. In 8l, 6l and 5l the function is Sconv(). For some reason, only 5l uses the constant STRINGSZ (defined as 200) for the buffer size. R=rsc http://codereview.appspot.com/168045 Committer: Russ Cox <rsc@golang.org>
Ross Light
json package: Fixed handling of nil values Fixes issue 400. R=golang-dev, rsc http://codereview.appspot.com/167058 Committer: Russ Cox <rsc@golang.org>
Ross Light
Added my name to the AUTHORS and CONTRIBUTORS list R=rsc http://codereview.appspot.com/165101 Committer: Russ Cox <rsc@golang.org>
Adrian O'Grady
Added XTEA block cipher package to src/pkg/crypto This is an adaption of the code from http://en.wikipedia.org/wiki/XTEA. The package also implements the block.Cipher interface so that it can be used with the various block modes. R=rsc http://codereview.appspot.com/157152 Committer: Russ Cox <rsc@golang.org>
Russ Cox
runtime: start new darwin/amd64 threads on correct stack, then enable stack check. R=r http://codereview.appspot.com/165100
Russ Cox
A+C: two more names Kei Son has completed the CLA. Yves Junqueira is a Google employee. R=r http://codereview.appspot.com/167057
Russ Cox
bufio: use copy - significant speedup for writers R=r http://codereview.appspot.com/167047
Devon O'Dell
Fix stack on FreeBSD / add stack check across the board FreeBSD was passing stk as the new thread's stack base, while stk is the top of the stack in go. The added check should cause a trap if this ever comes up in any new ports, or regresses in current ones. R=rsc CC=golang-dev http://codereview.appspot.com/167055 Committer: Russ Cox <rsc@golang.org>
Devon O'Dell
When SA_SIGINFO is set, we should use __sa_sigaction on FreeBSD R=rsc CC=golang-dev http://codereview.appspot.com/165097 Committer: Russ Cox <rsc@golang.org>
Russ Cox
6l, 8l: make string buffer big enough for 8 chars (and then some) Fixes issue 221. R=ken2 http://codereview.appspot.com/165086
Tags
weekly.2009-12-07
Russ Cox
test/bench: faster fasta (mostly due to bufio fix) R=r http://codereview.appspot.com/165083 Committer: Russ Cox <rsc@golang.org>
Russ Cox
runtime: don't touch pages of memory unnecessarily. cuts working size for hello world from 6 MB to 1.2 MB. still some work to be done, but diminishing returns. R=r http://codereview.appspot.com/165080
Russ Cox
runtime: introduce unsafe.New and unsafe.NewArray to provide functionality previously hacked in to reflect and gob. R=r http://codereview.appspot.com/165076
Robert Griesemer
use a bootstrap array to avoid allocation for short vectors R=r http://codereview.appspot.com/165078
cwedgwood
Remove copyBytes completely in favor of copy. R=r, rsc http://codereview.appspot.com/165068 Committer: Rob Pike <r@golang.org>
Rob Pike
pick off special one-byte case in copy. worth 2x in benchmarks (38ns->16ns). the one-item case could be generalized easily with no cost. worth considering. R=rsc CC=golang-dev, cw http://codereview.appspot.com/167044
rogpeppe
the AST walker currently provides no way to find out how the nodes in the tree are nested with respect to one another. a simple change to the Visitor interface makes it possible to do this (for example to maintain a current node-depth, or a knowledge of the name of the current function). Visit(nil) is called at the end of a node's children; this make possible the channel-based interface below, amongst other possibilities. It is still just as simple to get the original behaviour - just return the same Visitor from Visit. Here are a couple of possible Visitor types. // closure-based type FVisitor func(n interface{}) FVisitor func (f FVisitor) Visit(n interface{}) Visitor { retur…
rogpeppe
changes necessary to get the new chameneosredux onto shootout.alioth.debian.org . it's now there: http://shootout.alioth.debian.org/u32q/benchmark.php?test=chameneosredux&lang=all&box=1! R=r, rsc CC=golang-dev http://codereview.appspot.com/167043 Committer: Russ Cox <rsc@golang.org>
Rob Pike
save a few ns by inlining (which mostly simplifies things anyway). a couple of cleanups. don't keep big buffers in the free list. R=rsc CC=golang-dev http://codereview.appspot.com/166078
Rob Pike
unexport Fmt. it's not needed outside this package any more cleans up godoc's output for package fmt substantially. R=rsc CC=golang-dev http://codereview.appspot.com/165070
Rob Pike
Make printing faster by avoiding mallocs and some other advances. Roughly 33% faster for simple cases, probably more for complex ones. Before: mallocs per Sprintf(""): 4 mallocs per Sprintf("xxx"): 6 mallocs per Sprintf("%x"): 10 mallocs per Sprintf("%x %x"): 12 Now: mallocs per Sprintf(""): 2 mallocs per Sprintf("xxx"): 3 mallocs per Sprintf("%x"): 5 mallocs per Sprintf("%x %x"): 7 Speed improves because of avoiding mallocs and also by sharing a bytes.Buffer between print.go and format.go rather than copying the data back af…
Russ Cox
runtime: disable pointer scan optimization * broken by reflect, gob TBR=r http://codereview.appspot.com/166077
Ian Lance Taylor
Fix syscall.Statfs and syscall.Fstatfs for 386 GNU/Linux. For 386 we use the [f]statfs64 system call, which takes three parameters: the filename, the size of the statfs64 structure, and a pointer to the structure itself. R=rsc http://codereview.appspot.com/166073
Russ Cox
test/bench: use range in reverse-complement 1.9s gcc reverse-complement.c reverse-complement.go 4.5s / 3.5s original, with/without bounds checks 3.5s / 3.3s bounds check reduction 3.3s / 2.8s smarter garbage collector 2.6s / 2.3s assembler bytes.IndexByte 2.5s / 2.1s even smarter garbage collector 2.3s / 2.1s fix optimizer unnecessary spill bug 2.0s / 1.9s change loop to range (this CL) R=r http://codereview.appspot.com/166072
Russ Cox
gc/runtime: pass type structure to makeslice. * inform garbage collector about memory with no pointers in it 1.9s gcc reverse-complement.c reverse-complement.go 4.5s / 3.5s original, with/without bounds checks 3.5s / 3.3s bounds check reduction 3.3s / 2.8s smarter garbage collector 2.6s / 2.3s assembler bytes.IndexByte 2.5s / 2.1s even smarter garbage collector (this CL) R=r http://codereview.appspot.com/165064
  1. Prev
  2. Next