Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-09-07 R=dsymonds, rsc, r CC=golang-dev http://codereview.appspot.com/4968070
Tags
weekly.2011-09-07
Robert Griesemer
undo CL 4964067 / 661cb84cc6f0 API change. Needs further reflection. ««« original CL description path/filepath: Simplify Walk interface The last argument of filepath.Walk was removed, and the Visitor interface now contains an Error method that is called on errors. Fixes issue 2237. R=golang-dev, gri, r CC=golang-dev http://codereview.appspot.com/4964067 Committer: Robert Griesemer <gri@golang.org> »»» R=r CC=golang-dev ht…
Gustavo Niemeyer
path/filepath: Simplify Walk interface The last argument of filepath.Walk was removed, and the Visitor interface now contains an Error method that is called on errors. Fixes issue 2237. R=golang-dev, gri, r CC=golang-dev http://codereview.appspot.com/4964067 Committer: Robert Griesemer <gri@golang.org>
Russ Cox
gc: add -p flag to catch import cycles earlier The linker would catch them if gc succeeded, but too often the cycle manifests as making the current package and the imported copy of itself appear as different packages, which result in type signature mismatches that confuse users. As a crutch, add the -p flag to say 'if you see an import of this package, give up early'. Results in messages like (during gotest in sort): export_test.go:7: impor…
Russ Cox
net: sync CIDRMask code, doc R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4961069
hectorchu
5a, 5c, 6a, 6c, 8a, 8c: fix Windows file paths Verified with objdump -W. R=alex.brainman, rsc CC=golang-dev http://codereview.appspot.com/4974061 Committer: Russ Cox <rsc@golang.org>
Russ Cox
exp/regexp: bug fixes and RE2 tests Also add exp/regexp to build (forgot before). At this point I am very confident in exp/regexp's behavior. It should be usable as a drop-in replacement for regexp now. Later CLs could introduce a CompilePOSIX to get at traditional POSIX ``extended regular expressions'' as in egrep and also an re.MatchLongest method to change the matching mode to leftmost longest instead of leftmost first. On th…
Mikio Hara
net: ParseCIDR returns IPNet instead of IPMask Note that this CL will break your existing code which uses ParseCIDR. This CL changes ParseCIDR("172.16.253.121/28") to return the IP address "172.16.253.121", the network implied by the network number "172.16.253.112" and mask "255.255.255.240". R=rsc, borman CC=golang-dev http://codereview.appspot.com/4749043 Committer: Russ Cox <rsc@golang.org>
Lucio De Re
gc: silence Plan 9 warnings R=golang-dev CC=golang-dev, rsc http://codereview.appspot.com/4975055 Committer: Russ Cox <rsc@golang.org>
Ziad Hatahet
sort: use heapsort to bail out quicksort See http://research.swtch.com/2008/01/killing-quicksort.html for more info. Fixes issue 467. R=r, rsc CC=golang-dev http://codereview.appspot.com/4591051 Committer: Russ Cox <rsc@golang.org>
hectorchu
gopprof: regexp fixes Extract Windows filenames correctly. Don't remove receivers from method names. Fixes issue 2227. R=rsc CC=golang-dev http://codereview.appspot.com/4969059 Committer: Russ Cox <rsc@golang.org>
Russ Cox
A+C: Ziad Hatahet (individual CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4964066
Dmitriy Vyukov
sync/atomic: add Store functions R=rsc CC=golang-dev http://codereview.appspot.com/4950060
Russ Cox
image/png: check zlib checksum during Decode R=nigeltao CC=golang-dev http://codereview.appspot.com/4987041
Luuk van Dijk
gc: treat DOTMETH like DOT in escape analysis. Fixes issue 2225 R=rsc, nigeltao, dave CC=bradfitz, golang-dev, mikioh.mikioh http://codereview.appspot.com/4972056
dsymonds
weekly.html: remove note about exp/template -> template move. It actually occurred with the previous weekly snapshot. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/4961066
Robert Griesemer
cleanup: gofmt -s -w src misc R=r CC=golang-dev http://codereview.appspot.com/4984052
Rob Pike
template: slightly simplify the test for assignability of arguments R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4951066
Rob Pike
template: indirect or dereference function arguments if necessary to match the type of the formal. Fixes issue 2235 R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4967056
Robert Griesemer
go/parser: accept corner cases of signature syntax - func f(int,) is a legal signature - func f(...int,) is a legal signature Defer checking for correct use of "..." with last paremeter type to type checker instead of parser. R=rsc CC=golang-dev http://codereview.appspot.com/4973059
Robert Griesemer
gofmt: indent multi-line signatures There may be more fine-tuning down the line, but this CL fixes the most pressing issue at hand. Also: gofmt -w src misc Fixes issue 1524. R=rsc, bradfitz CC=golang-dev http://codereview.appspot.com/4975053
Russ Cox
url: handle ; in ParseQuery Most web frameworks allow ; as a synonym for &, following a recommendation in some versions of the HTML specification. Do the same. Remove overuse of Split. Move ParseQuery tests from package http to package url. Fixes issue 2210. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4973062
Russ Cox
gc: unify stack frame layout allocparams + tempname + compactframe all knew about how to place stack variables. Now only compactframe, renamed to allocauto, does the work. Until the last minute, each PAUTO variable is in its own space and has xoffset == 0. This might break 5g. I get failures in concurrent code running under qemu and I can't tell whether it's 5g's fault or qemu's. We'll see what the real ARM builders say.…
brainman
os: use GetFileAttributesEx to implement Stat on windows Fixes issue 2129. R=rsc CC=golang-dev http://codereview.appspot.com/4934049
Russ Cox
gc: fix zero-length struct eval Fixes issue 2232. R=ken2 CC=golang-dev http://codereview.appspot.com/4960054
Marcel van Lohuizen
exp/norm: performance improvements of quickSpan - fixed performance bug that could lead to O(n^2) behavior - performance improvement for ASCII case R=r, r CC=golang-dev http://codereview.appspot.com/4956060
Joel Sing
runtime: fix openbsd 386 raisesigpipe R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4950064 Committer: Russ Cox <rsc@golang.org>
Mikio Hara
syscall: update routing message attributes handling, fix typo R=fullung, golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4986041 Committer: Russ Cox <rsc@golang.org>
strings
build: clear execute bit from Go files R=golang-dev, rsc CC=golang-dev, mike.rosset http://codereview.appspot.com/4950062 Committer: Russ Cox <rsc@golang.org>
cwedgwood
runtime: add test for multiple concurrent channel consumers There was a time (in the past) when this wasn't robust. R=rsc, dvyukov CC=golang-dev http://codereview.appspot.com/4965058 Committer: Russ Cox <rsc@golang.org>
  1. Prev
  2. Next