Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-09-21 R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5075050
Tags
weekly.2011-09-21
Mike Samuel
exp/template/html: elide comments in template source. When templates are stored in external files, developers often embed comments to explain&|disable code. <!-- Oblique reference to project code name here --> {{if .C}}...{{else}}<!-- commented out default -->{{end}} This unnecessarily increases the size of shipped HTML and can leak information. This change elides all comments of the following types: 1. <!-- ... --> comments found in source. 2…
dsymonds
A&C: Add Paul Sbarra. R=golang-dev, adg CC=golang-dev, sbarra.paul http://codereview.appspot.com/5044045
Mike Samuel
exp/template/html: simplify transition functions This simplifies transition functions to make it easier to reliably elide comments in a later CL. Before: - transition functions are responsible for detecting special end tags. After: - the code to detect special end tags is done in one place. We were relying on end tags being skipped which meant we were not noticing comments inside script/style elements that contain no substitutions. This change…
Ian Lance Taylor
test: match gccgo error messages bug363.go:13:12: error: invalid context-determined non-integer type for shift operand bug363.go:16:12: error: invalid context-determined non-integer type for shift operand pointer.go:34:6: error: incompatible type in initialization (pointer to interface type has no methods) pointer.go:36:6: error: incompatible type in initialization method2.go:15:1: error: invalid pointer or interface receiver t…
Robert Griesemer
godoc: simplify internal FileSystem interface - also fixed bug: ReadFile never closed the file before - per suggestion by bradfitz R=bradfitz CC=golang-dev http://codereview.appspot.com/5092047
Robert Griesemer
gob: slightly simpler decodeUint R=r CC=golang-dev http://codereview.appspot.com/5089048
Robert Griesemer
gob: slightly simpler code for encodeUint R=r CC=golang-dev http://codereview.appspot.com/5077047
Gustavo Niemeyer
bytes: fix Replace so it actually copies The documentation for bytes.Replace says it copies the slice but it won't necessarily copy them. Since the data is mutable, breaking the contract is an issue. We either have to fix this by making the copy at all times, as suggested in this CL, or we should change the documentation and perhaps make better use of the fact it's fine to mutate the slice in place otherwise. R=golang-dev, bradfitz, a…
Brad Fitzpatrick
http: add a (disabled) test for TLS handshake timeouts It's currently broken and disabled, pending a fix for Issue 2281. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/5092045
Mike Samuel
exp/template/html: fix bug, '<' normalization for text nodes that change context R=nigeltao CC=golang-dev http://codereview.appspot.com/5080042
Ian Lance Taylor
test: match gccgo error messages Added a return to bug357.go to avoid an error which gccgo reports but 6g does not. bug353.go:16:14: error: reference to undefined identifer ‘io.ReadWriterCloser’ bug357.go:18:2: error: value computed is not used bug358.go:14:11: error: imported and not used: ioutil bug358.go:19:9: error: invalid use of type bug359.go:25:14: error: redefinition of ‘a’ bug359.go:25:6: note: previous definition o…
Ian Lance Taylor
test: match gccgo error messages for bug349.go bug349.go:12:14: error: expected ‘;’ or ‘}’ or newline bug349.go:12:2: error: not enough arguments to return R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/5081047
Ian Lance Taylor
test: match gccgo error messages for goto.go and bug344.go goto.go:39:2: error: goto jumps over declaration of ‘x’ goto.go:40:2: note: ‘x’ defined here goto.go:57:2: error: goto jumps over declaration of ‘x’ goto.go:62:2: note: ‘x’ defined here goto.go:77:2: error: goto jumps over declaration of ‘x’ goto.go:78:2: note: ‘x’ defined here goto.go:87:2: error: goto jumps over declaration of ‘x’ goto.go:88:2: note: ‘x’ defined here goto.go:114:2: error: goto j…
Robert Griesemer
suffixarray: improved serialization code Use gobs to serialize indexes instead of encoding/binary. Even with gobs, serialize data in slices instead of applying gob to the entire data structure at once, to reduce the amount of extra buffer memory needed inside gob. 7x faster Write/Read for new BenchmarkSaveRestore compared to old code; possibly because encoding/binary is more expensive for int32 slice elements (interface call to get lit…
Rob Pike
reflect: add comment about the doubled semantics of Value.String. R=rsc CC=golang-dev http://codereview.appspot.com/5091044
Brad Fitzpatrick
httptest: add NewUnstartedServer This allows testing TLS with different http.Server options (timeouts, limits). R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5094043
Russ Cox
codereview: save CL messages in $(hg root)/last-change Fixes issue 2279. R=bradfitz, r, r CC=golang-dev http://codereview.appspot.com/5096042
Rob Pike
gob: fix allocation for singletons. Code was double-allocating in some cases. Fixes issue 2267. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5093042
Ian Lance Taylor
test: match gccgo error message for bug337.go bug337.go:17:2: error: value computed is not used R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5094042
Dave Cheney
exp/ssh: refactor halfConnection to transport This CL generalises the pair of halfConnection members that the serverConn holds into a single transport struct that is shared by both Server and Client, see also CL 5037047. This CL is a replacement for 5040046 which I closed by accident. R=agl, bradfitz CC=golang-dev http://codereview.appspot.com/5075042 Committer: Adam Langley <agl@golang.org>
Mike Samuel
exp/template/html: change transition functions to return indices Formulaic changes to transition functions in preparation for CL 5074041. This should be completely semantics preserving. R=nigeltao CC=golang-dev http://codereview.appspot.com/5091041
Brad Fitzpatrick
http: fix TLS handshake blocking server accept loop Fixes issue 2263 R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/5076042
Mike Samuel
exp/template/html: allow commenting out of actions Instead of erroring on actions inside comments, use existing escaping pipeline to quash the output of actions inside comments. If a template maintainer uses a comment to disable template code: {{if .}}Hello, {{.}}!{{end}} -> <!--{{if true}}Hello, {{.}}!{{end}}--> will result in <!--Hello, !--> regardless of the value of {{.}}. In a later CL, comment elision will result in the entire …
Mike Samuel
exp/template/html: define isComment helper Non semantics-changing refactoring in preparation for comment elision. R=nigeltao CC=golang-dev http://codereview.appspot.com/5071043
Rob Pike
gob: don't allocate a slice if there's room to decode already Fixes issue 2275. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/5082041
Ian Lance Taylor
doc: when configuring gold for gccgo, use --enable-gold=default R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5030057
Dave Grijalva
http: always include Content-Length header, even for 0 fixes issue 2221 R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/4952052 Committer: Brad Fitzpatrick <bradfitz@golang.org>
Dmitriy Vyukov
sync/atomic: replace MFENCE with LOCK XADD MFENCE was introduced only on the Pentium4 (SSE2), while XADD was introduced on the 486. Fixes issue 2268. R=golang-dev, rsc CC=fshahriar, golang-dev http://codereview.appspot.com/5056045
Eric Roshan Eisner
suffixarray: generate less garbage during construction Minorly improves runtime by about 2-3% R=gri, jeff CC=golang-dev http://codereview.appspot.com/5052045 Committer: Robert Griesemer <gri@golang.org>
  1. Prev
  2. Next