Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-10-06 R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5207044
Tags
weekly.2011-10-06
Rob Pike
template: fix comments with different delimiters. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5208042
Rob Pike
template: add method Delims to allow alternate action delimiters. R=golang-dev, rsc, dsymonds CC=golang-dev http://codereview.appspot.com/5209045
Andrew Gerrand
doc: remove errant console.log from godocs.js R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5211045
Andrew Gerrand
go/doc, godoc, gotest: support for reading example documentation This CL introduces the go.Example type and go.Examples functions that are used to represent and extract code samples from Go source. They should be of the form: // Output of this function. func ExampleFoo() { fmt.Println("Output of this function.") } It also modifies godoc to read example code from _test.go files, and include them in the HTML output with JavaScript-driven toggles. It a…
Brad Fitzpatrick
exec: add Command.ExtraFiles Allows passing extra fds to the child process. Fixes issue 2329 R=rsc, dsymonds CC=golang-dev http://codereview.appspot.com/5162050
Rob Pike
Effective Go: IntArray -> IntSlice Fixes issue 2336. R=golang-dev, dsymonds, rsc CC=golang-dev http://codereview.appspot.com/5222042
Rob Pike
gotest: document -test.parallel R=golang-dev, bradfitz, dsymonds, gri CC=golang-dev http://codereview.appspot.com/5223043
Miki Tebeka
testing: Add support for running tests in parallel (t.Parallel API). See discussion at https://groups.google.com/d/topic/golang-dev/RAKiqi44GEU/discussion R=golang-dev, bradfitz, dvyukov, rogpeppe, r, r, borman CC=golang-dev http://codereview.appspot.com/5071044 Committer: Rob Pike <r@golang.org>
Rob Pike
C+A: Miki Tebeka miki.tebeka@gmail.com R=golang-dev, gri CC=golang-dev, miki.tebeka http://codereview.appspot.com/5225042
Dmitriy Vyukov
runtime: faster finalizers Linux/amd64, 2 x Intel Xeon E5620, 8 HT cores, 2.40GHz benchmark old ns/op new ns/op delta BenchmarkFinalizer 420.00 261.00 -37.86% BenchmarkFinalizer-2 985.00 201.00 -79.59% BenchmarkFinalizer-4 1077.00 244.00 -77.34% BenchmarkFinalizer-8 1155.00 180.00 -84.42% BenchmarkFinalizer-16 1182.00 …
Russ Cox
runtime: fix malloc sampling bug The malloc sample trigger was not being set in a new m, so the first allocation in each new m - the goroutine structure - was being sampled with probability 1 instead of probability sizeof(G)/rate, an oversampling of about 5000x for the default rate of 1 MB. This bug made pprof graphs show far more G allocations than there actually were. R=golang-dev, r CC=golang-dev http://codereview.appspot.co…
Dmitriy Vyukov
runtime: fix spurious deadlock reporting Fixes issue 2337. Unfortunate sequence of events is: 1. maxcpu=2, mcpu=1, grunning=1 2. starttheworld creates an extra M: maxcpu=2, mcpu=2, grunning=1 4. the goroutine calls runtime.GOMAXPROCS(1) maxcpu=1, mcpu=2, grunning=1 5. since it sees mcpu>maxcpu, it calls gosched() 6. schedule() deschedules the goroutine: maxcpu=1, mcpu=1, grunning=0 7. schedule() call getnextandunlock() which fails to pick up the goroutine again, because canaddcpu() fails, because mcpu==maxcpu 8. then it sees that grunning==0, reports deadlock and terminates R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5191044
Mikio Hara
build: clear execute bit from source files R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/5201042
vcc
cgo: support for mingw-w64 4.5.1 and newer R=rsc, jp, hectorchu CC=golang-dev http://codereview.appspot.com/4962051 Committer: Hector Chu <hectorchu@gmail.com>
Marcel van Lohuizen
exp/norm: LastBoundary is used in preparation for an append operation. It seems therefore unlikely that there is a good use for its string version LastBoundaryInString. Yet, the implemenation of this method would complicate things a bit as it would require the introduction for another interface and some duplication of code. Removing it seems a better choice. R=r CC=golang-dev http://codereview.appspot.com/5182044
Andrew Gerrand
tag release.r60.2 R=bradfitz CC=golang-dev http://codereview.appspot.com/5208041
Andrew Gerrand
doc: document r60.2 R=rsc, dsymonds CC=golang-dev http://codereview.appspot.com/5204041
Robert Griesemer
encoding/binary: added benchmarks binary.BenchmarkPutUvarint32 20000000 85.6 ns/op binary.BenchmarkPutUvarint64 10000000 299 ns/op R=rsc CC=golang-dev http://codereview.appspot.com/5148049
Andrew Gerrand
doc: link to Czech translation of The Laws of Reflection R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5190045
Andrew Gerrand
doc: link to A Tour of Go R=golang-dev, rsc, r CC=golang-dev http://codereview.appspot.com/5181045
Fumitoshi Ukai
websocket: add hybi-13 support Major changes between hybi-08 and hybi-13 - hybi-08 uses Sec-WebSocket-Origin, but hybi-13 uses Origin - hybi-13 introduces new close status codes. hybi-17 spec (editorial changes of hybi-13) mentions - if a server doesn't support the requested version, it MUST respond with Sec-WebSocket-Version headers containing all available versions. - client MUST close the connection upon receiving a maske…
Luuk van Dijk
documentation: Debugging Go code with GDB tutorial. R=adg, cw, lvd CC=golang-dev http://codereview.appspot.com/5168046 Committer: Andrew Gerrand <adg@golang.org>
Marcel van Lohuizen
exp/norm: introduced input interface to implement string versions of methods. R=r, mpvl CC=golang-dev http://codereview.appspot.com/5166045
Robert Griesemer
ebnf: use scanner instead of go/scanner R=rsc, r CC=golang-dev http://codereview.appspot.com/5192043
Joel Sing
runtime: set runtime ncpu on openbsd Set the runtime ncpu based on the hw.ncpu sysctl. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5191043 Committer: Russ Cox <rsc@golang.org>
Rob Pike
gob: when possible, allow sequential decoders on the same input stream. This can work only if there is no type info required to initialize the decoder, but it's easy and gains a few percent in the basic benchmarks by avoiding bufio when it's a bytes.Buffer - a testing-only scenario, I admit. Add a comment about what Decode expects from the input. R=rsc CC=golang-dev http://codereview.appspot.com/5165048
Russ Cox
misc/emacs: fix indent bug Must use case-sensitive search to identify keywords. Fixes issue 2287. R=bradfitz CC=golang-dev http://codereview.appspot.com/5182043
Russ Cox
codereview: fix for Mercurial 1.9.2 R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/5127052
Joel Sing
gc: limit helper threads based on ncpu When ncpu < 2, work.nproc is always 1 which results in infinite helper threads being created if gomaxprocs > 1 and MaxGcproc > 1. Avoid this by using the same limits as imposed helpgc(). R=golang-dev, rsc, dvyukov CC=golang-dev http://codereview.appspot.com/5176044 Committer: Russ Cox <rsc@golang.org>
  1. Prev
  2. Next