Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-10-25 R=rsc CC=golang-dev http://codereview.appspot.com/5321053
Tags
weekly.2011-10-25
Andrew Balholm
html: improve parsing of lists Make a <li> tag close the previous <li> element. Make a </ul> tag close <li> elements. Pass tests1.dat, test 33: <!DOCTYPE html><li>hello<li>world<ul>how<li>do</ul>you</body><!--do--> | <!DOCTYPE html> | <html> | <head> | <body> | <li> | "hello" | <li> | "world" | <ul> | "how" | <li> | "do" | "you" | <!-- do --> R=nigeltao CC=golan…
Andrew Balholm
html: improve parsing of tables When foster parenting, merge adjacent text nodes. Properly close table row at </tr> tag. Pass tests1.dat, test 32: <!-----><font><div>hello<table>excite!<b>me!<th><i>please!</tr><!--X--> | <!-- - --> | <html> | <head> | <body> | <font> | <div> | "helloexcite!" | <b> | "me!" | <table> | <tbody> | <tr> | <th> | …
Ian Lance Taylor
syscall: correct name of mksyscall script in comment R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5310055
hectorchu
runtime: include bootstrap m in mcpu accounting R=rsc, dvyukov CC=golang-dev http://codereview.appspot.com/5307052
Brad Fitzpatrick
http: doc typo R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5303067
David Anderson
syscall: use uintptr for Mount flags. R=bradfitz, rsc CC=golang-dev http://codereview.appspot.com/5308044 Committer: Brad Fitzpatrick <bradfitz@golang.org>
Nigel Tao
html: remove the Tokenizer.ReturnComments option. The original intention was to simplify the parser, in making it skip all comment tokens. However, checking that the Go html package is 100% compatible with the WebKit HTML test suite requires parsing the comments. There is no longer any real benefit for the option. R=gri, andybalholm CC=golang-dev http://codereview.appspot.com/5321043
Dave Cheney
exp/ssh: introduce Session to replace Cmd for interactive commands This CL replaces the Cmd type with a Session type representing interactive channels. This lays the foundation for supporting other kinds of channels like direct-tcpip or x11. client.go: * replace chanlist map with slice. * generalize stdout and stderr into a single type. * unexport ClientChan to clientChan. doc.go: * update ServerConfig/ServerConn documentation. * update Client example for Sessi…
Andrew Balholm
html: dump attributes when running parser tests. The WebKit test data shows attributes as though they were child nodes: <a X>0<b>1<a Y>2 dumps as: | <html> | <head> | <body> | <a> | x="" | "0" | <b> | "1" | <b> | <a> | y="" | "2" So we need to do the same when dumping a tree to compare with it. R=nigeltao CC=golang-dev http://codereview.appspot.com/5322044 Committer: Nigel Tao <nige…
Brad Fitzpatrick
http: add package comment Fixes issue 2378 R=rsc CC=golang-dev http://codereview.appspot.com/5312052
brainman
net: do not set SO_REUSEADDR for windows Fixes issue 2307. R=golang-dev, mikioh.mikioh CC=golang-dev http://codereview.appspot.com/5306049
Andrew Balholm
html: implement foster parenting Implement the foster-parenting algorithm for content that is inside a table but not in a cell. Also fix a bug in reconstructing the active formatting elements. Pass test 30 in tests1.dat: <a><table><td><a><table></table><a></tr><a></table><b>X</b>C<a>Y R=nigeltao CC=golang-dev http://codereview.appspot.com/5309052 Committer: Nigel Tao <nigeltao@golang.org>
Nigel Tao
html: parse <select> tags. The additional test case in parse_test.go is: <select><b><option><select><option></b></select>X R=andybalholm CC=golang-dev http://codereview.appspot.com/5293051
Robert Griesemer
big: usable zero Rat values without need for explicit initialization - no explicit API change, but new(big.Rat) now creates a big.Rat value of 0 that is immediately usable, in sync. w/ the conventions elsewhere - various cleanups along the way R=r CC=golang-dev http://codereview.appspot.com/5301056
Rob Pike
fmt: simplify the code some more by storing the field in the pp structure. R=rsc CC=golang-dev http://codereview.appspot.com/5293058
Robert Griesemer
big: implemented Rat.Inv Also: - changed semantics of return values for [Int|Rat].SetString if an error occured (returned value is nil); will expose hidden errors where return values are not checked - added more tests - various cleanups throughout Fixes issue 2384. R=r CC=golang-dev http://codereview.appspot.com/5312044
Rob Pike
gotest: make it easier to get the help string Because gotest's args are mingled with the tests, it's hard to get the usage message to print. This CL adds explicit support for -help, spelled several different ways. Gotest has special flags like -file that are somewhat hidden otherwise. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5298052
Brad Fitzpatrick
http: Transport: with TLS InsecureSkipVerify, skip hostname check Fixes issue 2386 R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5312045
Dave Cheney
exp/ssh: server cleanups server.go/channel.go: * rename Server to ServerConfig to match Client. * rename ServerConnection to ServeConn to match Client. * add Listen/Listener. * ServerConn.Handshake(), general cleanups. client.go: * fix bug where fmt.Error was not assigned to err R=rsc, agl CC=golang-dev http://codereview.appspot.com/5265049 Committer: Adam Langley <agl@golang.org>
Dave Cheney
exp/ssh: add experimental ssh client Requires CL 5285044 client.go: * add Dial, ClientConn, ClientChan, ClientConfig and Cmd. doc.go: * add Client documentation. server.go: * adjust for readVersion change. transport.go: * return an os.Error not a bool from readVersion. R=rsc, agl, n13m3y3r CC=golang-dev http://codereview.appspot.com/5162047 Committer: Adam Langley <agl@golang.org>
Robert Griesemer
go/ast: use single-element map in test Avoids test failure due to undefined map iteration order. R=rsc, iant, iant CC=golang-dev http://codereview.appspot.com/5297048
Ian Lance Taylor
go/ast, go/token: actually run tests; fix go/ast test R=gri CC=golang-dev http://codereview.appspot.com/5292048
hectorchu
exp/winfsnotify: fix test R=alex.brainman, mattn.jp CC=golang-dev http://codereview.appspot.com/5311047
Nigel Tao
html: parse and render comment nodes. The first additional test case in parse_test.go is: <!--><div>--<!--> The second one is unrelated to the comment change, but also passes: <p><hr></p> R=andybalholm CC=golang-dev http://codereview.appspot.com/5299047
Dave Cheney
misc/vim: add highlighting for delete R=golang-dev, n13m3y3r CC=golang-dev http://codereview.appspot.com/5303050 Committer: Gustavo Niemeyer <gustavo@niemeyer.net>
Gustavo Niemeyer
fmt: don't panic formatting nil interfaces R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5296044
Russ Cox
govet: check canonical dynamic method signatures Adds check that, for example, a Scan method taking a first argument of type fmt.ScanState has the correct signature to satisfy fmt.Scanner. Similarly, a ReadByte should return byte, os.Error. These are important to check because various pieces of code (fmt, gob, json, flate) do dynamic checks for these methods, so code with incorrect signatures would not be flagged at compile time. These become…
Russ Cox
unicode: sort tables.go Makes tables.go output consistent across maketable runs. (It was already inconsistent across architectures; the new map iteration order just make it inconsistent across runs.) R=r CC=golang-dev http://codereview.appspot.com/5303046
Russ Cox
codereview: show LGTMs in hg p Shows first line of any response that the codereview server has identified as an LGTM. Example output below. 5305046: big: update for fmt interface changes Nothing terribly interesting here. Reviewer: gri@golang.org gri: LGTM CC: golang-dev@googlegroups.com Files: src/pkg/big/int.go src/pkg/big/nat.go …
  1. Prev
  2. Next