Commits

Show all
Author Commit Message Labels Comments Date
Nigel Tao
weekly.2012-01-20 R=r CC=golang-dev http://codereview.appspot.com/5557067
Tags
weekly.2012-01-20
Mikio Hara
net: fix linux build R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5558056 Committer: Brad Fitzpatrick <bradfitz@golang.org>
brainman
misc/cgo/test: make tests run on windows - use proper Win64 gcc calling convention when calling initcgo on amd64 - increase g0 stack size to 64K on amd64 to make it the same as 386 - implement C.sleep - do not use C.stat, since it is renamed to C._stat by mingw - use fopen to implement TestErrno, since C.strtol always succeeds on windows - skip TestSetEnv on windows, because os.Setenv sets windows process environment, while C.get…
Brad Fitzpatrick
database/sql: move from exp/sql R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5536076
Gustavo Niemeyer
html/template: fix docs after API changes R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5528109
Brad Fitzpatrick
os: use FileMode instead of uint32 in various functions Fixes issue 2733 R=chickencha, ality, rsc CC=golang-dev http://codereview.appspot.com/5553064
Nigel Tao
image: change the YCbCr image's pixel buffers to start at Rect.Min instead of the origin. This makes YCbCr match the other image types (e.g. RGBA, Gray) in that an image's bounds is not restricted to the positive quadrant. Also optimize the YCbCr draw code by hoisting some computation outside of the loop. benchmark old ns/op new ns/op delta draw.BenchmarkYCbCr 2544418 2373558 -6.72% Like http://codereview.appspot.com/4681044/ I don't think a gofix is f…
Mikio Hara
net: fix windows build R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/5532102
Mikio Hara
net: fix broken setDefaultSockopts R=rsc, bradfitz CC=golang-dev http://codereview.appspot.com/5536068
Luit van Drongelen
crypto/hmac: Deprecate hmac.NewMD5, hmac.NewSHA1 and hmac.NewSHA256 Remove NewMD5, NewSHA1 and NewSHA256 in favor of using New and explicitly importing the used hash-function. This way when using, for example, HMAC with RIPEMD there's no md5, sha1 and sha256 linked in through the hmac package. A gofix rule is included, and applied to the standard library (3 files altered). This change is the result of a discussion at http://codereview.appspot.com/5550043/ to pul…
dsymonds
gc: don't emit pkgpath for error type. Fixes issue 2660. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5557060
Brad Fitzpatrick
net/http: log handler panic before closing HTTP connection Fix originally from rogpeppe in 5414048 but was rolled back due to test breakage. This CL makes the test more robust to order of operations. Fixes issue 2480 again. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/5536072
Gustavo Niemeyer
os/exec: trivial allocation removal in LookPath R=golang-dev, bsiegert, r CC=golang-dev http://codereview.appspot.com/5549043
Gustavo Niemeyer
encoding/xml: marshal/unmarshal xml.Name in field R=rsc CC=golang-dev http://codereview.appspot.com/5542052
minux
doc: update out-of-date comments about runtime/cgo R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5532100 Committer: Russ Cox <rsc@golang.org>
Robert Griesemer
go/parser: expressions may have comments Thanks to 0xE2.0x9A.0x9B for the patch suggestion. Fixes issue 2739. R=r CC=golang-dev http://codereview.appspot.com/5536071
Rob Pike
text/template/parse: use human error prints The previous version of all the node.String methods printed the parse tree and was useful for developing the parse tree code. Now that that's done, we might as well print the nodes using the standard template syntax. It's much easier to read and makes error reporting look more natural. Helps issue 2644. R=rsc, n13m3y3r CC=golang-dev http://codereview.appspot.com/5553066
Dave Cheney
runtime: madvise and SysUnused for Darwin SysUnused is a direct call to madvise MADV_FREE. R=sebastien.paolacci, rsc, minux.ma CC=golang-dev http://codereview.appspot.com/5531073 Committer: Russ Cox <rsc@golang.org>
Andrew Gerrand
godoc: support canonical Paths in HTML metadata Redirect to the canonical path when the old path is accessed. R=gri CC=golang-dev http://codereview.appspot.com/5536061
Evan Shaw
os: add ModeSticky R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5539063 Committer: Brad Fitzpatrick <bradfitz@golang.org>
minux
testing: do not recover example's panic So as to give out stack trace for panic in examples. This behavior also matches the tests'. Fixes issue 2691. R=golang-dev CC=golang-dev http://codereview.appspot.com/5554061 Committer: Rob Pike <r@golang.org>
Olivier Duperray
pkg: Add & fix Copyright of "hand generated" files R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5554064 Committer: Rob Pike <r@golang.org>
Brad Fitzpatrick
exp/sql: rename NullableString to NullString and allow its use as a parameter Prep for Issue 2699 R=rsc CC=golang-dev http://codereview.appspot.com/5536045
Robert Griesemer
go/doc, godoc: don't shadow receiver Fixes issue 2737. R=bradfitz CC=golang-dev http://codereview.appspot.com/5553062
Christoph Hack
net/http: the documentation should call NewRequest with the right signature. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5554063 Committer: Brad Fitzpatrick <bradfitz@golang.org>
Adam Langley
crypto/x509: remove explicit uses of rsa. (Sending to r because of the API change.) Over time we might want to add support for other key types. While I was in the code, I also made the use of RawSubject the same between Subject and Issuer when creating certificates. R=r, rsc CC=golang-dev http://codereview.appspot.com/5554049
Adam Langley
crypto/elliptic: add constant-time P224. (Sending to r because of the API change.) This change alters the API for crypto/elliptic to permit different implementations in the future. This will allow us to add faster, constant-time implementations of the standard curves without any more API changes. As a demonstration, it also adds a constant-time implementation of P224. Since it's only 32-bit, it's actually only about 40% the speed of th…
Dmitriy Vyukov
math/rand: decrease test duration in short mode TestNonStandardNormalValues runs 1.5s, the change reduces it to 0.2s in short mode. The problem is with slow machines, emulators and dynamic tools. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5540065
Andrew Gerrand
godoc: add anchors to cmd documentation headings Also, disable server-side generation of TOC for commands as they would only ever show Overview. The JS does a better job (for now). Fixes issue 2732. R=gri, dsymonds CC=golang-dev http://codereview.appspot.com/5558046
Nigel Tao
html: in foreign content, check for HTML integration points in breakout elements. Pass tests10.dat, test 33: <!DOCTYPE html><svg><desc><svg><ul>a | <!DOCTYPE html> | <html> | <head> | <body> | <svg svg> | <svg desc> | <svg svg> | <ul> | "a" Also pass test 34: <!DOCTYPE html><p><svg><desc><p> R=andybalholm, dsymonds CC=golang-dev http://codereview.appspot.com/5536048
  1. Prev
  2. Next