1. David Larlet
  2. django-storages

Issues

Issue #169 resolved

Setting content-disposition = attachment with S3Boto

Greg Taylor
created an issue

We have the need to adjust the content-disposition header that S3 returns, and I wanted to see if there was any way we could work this into django-storages.

I'm working on getting django-athumb to use django-storages instead of the storages fork I did ages ago to make some custom performance-related changes long ago. Here's what my current download-as-attachment looks like right now:

https://github.com/gtaylor/django-athumb/blob/master/athumb/backends/s3boto.py#L216

I have it as a separate method so I'm not changing the signature of url(). This falls outside of the Django storage API, but I couldn't find another great way to do this while re-using the rest of the storage backend's magic.

boto handles this, but I figured it'd be better to go through the storage backend, rather than go at it manually (what would be the point of having this storage backend abstraction?).

If you're interested, let me know how you'd like me to work this in and I'll send a PR.

Comments (4)

  1. Log in to comment