James Dumay avatar James Dumay committed 565a983

ExternalProcess could not be interrupted because it ignored InterruptedException

Comments (0)

Files changed (1)

src/main/java/com/atlassian/utils/process/ExternalProcess.java

                     awaitPump(outputPump, checkTime);
                     awaitPump(inputPump, checkTime);
                     awaitPump(errorPump, checkTime);
-                } while (!isTimedOut() && arePumpsRunning());
+                } while (!isTimedOut() && arePumpsRunning() && !Thread.currentThread().isInterrupted());
+
+                if (Thread.currentThread().isInterrupted() && arePumpsRunning()) {
+                    cancel();
+                }
             } finally {
                 int exitCode = 0;
                 if (!cancelled) {
     private int wrapUpProcess() {
         int exitCode = -1;
         boolean processIncomplete = true;
+        boolean interrupted = false;
         try {
             exitCode = process.exitValue();
             processIncomplete = false;
                     exitCode = process.exitValue();
                     processIncomplete = false;
                 } catch (InterruptedException e1) {
-                    // just ignore
+                    processIncomplete = true;
+                    interrupted = true;
+                    break;
                 } catch (IllegalThreadStateException e2) {
                     // ignore and try in the next loop
                 }
             }
         } finally {
-            process.destroy();
-        }
-
-        // make sure pumps are done
-        if (arePumpsRunning()) {
             cancel();
         }
 
-        if (processIncomplete) {
+        if (processIncomplete && !interrupted) {
             processException = new ProcessTimeoutException("process timed out");
         }
         return exitCode;
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.