Commits

James Dumay committed d5ca019

We should disable the windows encoding work around by default

  • Participants
  • Parent commits 5b368c6

Comments (0)

Files changed (3)

File src/main/java/com/atlassian/utils/process/ExternalProcess.java

  * the process' IO requirements.
  */
 public class ExternalProcess implements Watchdog {
-    private boolean useWindowsEncodingWorkaround = true;
+    private boolean useWindowsEncodingWorkaround = false;
     private List<String> command;
     private File workingDir;
     private Map<String, String> environment;

File src/main/java/com/atlassian/utils/process/ExternalProcessBuilder.java

         return this;
     }
 
-    public ExternalProcessBuilder disableWindowsEncodingWorkaround()
+    public ExternalProcessBuilder useWindowsEncodingWorkaround()
     {
         this.disableWindowsEncodingWorkaround = true;
         return this;
 
         if (disableWindowsEncodingWorkaround)
         {
-            process.setUseWindowsEncodingWorkaround(false);
+            process.setUseWindowsEncodingWorkaround(true);
         }
 
         return process;

File src/test/java/com/atlassian/utils/process/CallEcho.java

                         protected void processLine(int lineNum, String line) {
                             System.err.println(line);
                         }
-                    }).build();
+                    })
+                    .useWindowsEncodingWorkaround()
+                    .build();
             process.setEnvironment(echoEnv);
             process.execute();