1. David Black
  2. atlassian-soy-templates

Branches

SOY-3-thread-safe-manager

View source
SOY-3-thread-safe-manager
  • Related issues SOY-3
  • Contributors
    1. Loading...
Author Commit Message Date Builds
115 commits behind master.
Don Willis [Atlassian]
SOY-3 Fixed one broken test case, Ignored the other - If we always construct the default injector before we construct any others, the then default injector and the first subsequent injector will always work (since the subsequent injector doesn't break the default one) - However I do not know how to fix intermingled non-default injectors. Requires more time investigating exactly how they're broken, which I don't have.
Don Willis [Atlassian]
SOY-3 Wrote SoyDependencyInjectorFactoryTest, which fails.
Don Willis [Atlassian]
Merge branch 'SOY-3-thread-safe-manager' of bitbucket.org:atlassian/atlassian-soy-templates into SOY-3-thread-safe-manager Conflicts: soy-template-plugin/src/main/java/com/atlassian/soy/impl/DefaultSoyManager.java
Matt "Spuddy" Quail
SOY-3: extra debugging
Matt "Spuddy" Quail
SOY-3: partial unit test for stuff
Don Willis [Atlassian]
SOY-3 more refactoring of DefaultSoyManager - Pulled the Injector Making and Caching into a new class: SoyDependencyInjectorFactory. - Made the key of the SoyDependencyInjectorFactory the FunctionModuleData from the FunctionModuleDataFactory, so it doesn't need to make its own call to that factory, and because it only depends on it, not the list. - Pulled the FunctionModuleData into its own package-private class and gave it a hashcode and …
Don Willis [Atlassian]
SOY-3 more debugging
Don Willis [Atlassian]
SOY-3 Split FunctionModuleDataFactory out of DefaultSoyManager and added lots of debugging. Don't merge this branch in this state.
Don Willis [Atlassian]
SOY-3 Stopped trusting Iterables.concat and added debuging
Don Willis [Atlassian]
SOY-3 stopped using ArrayLists as keys in shared maps - I'm hoping that the reason we are seeing flakiness in the presence of functions is due to this lack of thread safety.