Anonymous avatar Anonymous committed bae3001

Change the stack frame regular expression to use named groups instead of group numbers, to make the expression self-documenting.

Comments (0)

Files changed (1)

 		return None
 
 def symbolicate_backtrace_line(line):
-	match = re.match('[0-9]+\s+([-_a-zA-Z\./]+)\s+(0x[0-9A-Fa-f]+)\s+', line)
+	match = re.match('(?P<frame_number>[0-9]+)\s+(?P<bundle_ID>[-_a-zA-Z\./]+)\s+(?P<address>0x[0-9A-Fa-f]+)\s+', line)
 	if not match:
 		return line
 
-	bundle_ID = match.group(1)
-	address = match.group(2)
+	bundle_ID = match.group('bundle_ID')
+	address = match.group('address')
 
 	function_info = look_up_address_by_bundle_ID(bundle_ID, address)
 	if function_info is None:
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.