bug with file object

Philippe Lagadec avatarPhilippe Lagadec created an issue

reported on http://www.decalage.info/en/python/olefileio#comment-481

I passed a file() to OleFileIO() and got an error in this line 979: filesize = os.path.getsize(filename) but in line 847 you check for a file object if hasattr(filename, 'read'):

Potential solutions:

  • use name method of file object before calling getsize (only works with real files)
  • use seek(os.SEEK_END) then tell (only works with seekable file objects)
  • do not allow file-like objects
  • read all data then check len

I think the seek/tell solution is the most appropriate, since other parts of the code require seekable file objects anyway. Non-seekable file objects could be read into memory and converted to a StringIO beforehand.

Comments (2)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.