derschreckliche avatar derschreckliche committed ce1d26b

Added a hack to support all kinds of HttpResponse

Comments (0)

Files changed (1)

djangorators/rendering.py

 from django.views.generic.simple import direct_to_template
-from django.http import HttpResponse, HttpResponseRedirect, HttpResponseNotFound
+from django.http import HttpResponse
 
 def as_html(template_name):
     def wrap(func):
         def _dec(request, *args, **kwargs):
             response = func(request, *args, **kwargs)
-            # TODO: add more, or even better find an elegant hack :)
-            http_responses = (HttpResponse, HttpResponseRedirect, HttpResponseNotFound)
-            if isinstance(response, http_responses):
+            if issubclass(response.__class__, HttpResponse):
                 return response
             # Otherwise, the response is a context which is rendered
             return direct_to_template(request, template_name, response)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.