Issue #4 resolved

Option to ignore a LogicalOr that ends with a literal

Erik Simmler avatarErik Simmler created an issue

I use a lot of idioms such as foo = bar or {} ... which means that it will never evaluate to "F T". Instrumental does recognize the presence of a literal, but these still clutter up my results.

Just a thought. Issue #2 would give a good way to at least mark these as "ok".

Awesome tool!

Comments (6)

  1. desmaj

    There's been work on a system to address issue #2, but it's a long way from being ready. Maybe a good idea would be to include an option to ignore expressions with zero or one variable inputs unless the expression is used in a decision context. This might require more powerful static analysis than we currently have, but I'll give it a go. Thanks!

  2. Erik Simmler

    Awesome! Seems to do the trick at first glance. I'm actually gearing up for a bit of a coverage sweep, so I'll put it through more paces.

    I'd consider this one closed. Thanks!!

  3. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.