Memory leaks

[Jean-Luc Gyger]

Hi, I think that in QJsonRpcHttpReply::networkReplyFinished and in QJsonRpcHttpReply::networkReplyError you have a memory leaks.

Indeed, It seems to me that "reply" is never delete. You should add reply->deleteLater(); before Q_EMIT finished();

[Matt Broadstone]

https://bitbucket.org/devonit/qjsonrpc/src/b83726b8ce72a9d1a201cfeee80802c21734066e/src/qjsonrpchttpclient.cpp?at=master#cl-236

[Jean-Luc Gyger]

Not sure that solved the problem. Indeed, this is ok when using the notify function because you don't wait a response. But when using sendMessage, the reply shoud be delete on networkReplyFinished or networkReplyError .

[Matt Broadstone]

oh my bad, yeah looks like there is one in sendMessage. A normal QJsonRpcSocket uses notify internally to send the messages, not the case here.

[Matt Broadstone]

fixed here: https://bitbucket.org/devonit/qjsonrpc/commits/469db9ed89c82ae8f043d1ddb54d51ab27e5f80d