Many test programs deletes services twice

[Jochen Becher]

Calling QJsonRpcAbstractServer::addService adds the given service to a QObjectCleanupHandler instance which will delete all added services in its destructor. Thus a new service must be allocated on heap and may not be deleted manually or it must be declared after the server object (which will remove it automatically from the server's QObjectCleanupHandler instance when the service is automatically destructed before the server).

[Matt Broadstone]

Can you describe which tests you think do this? Most of the qjsonrpc*server tests start init each test with a new server, and then do a server->addService(new TestService). Last time I used valgrind on the tests there were no memory leaks or double deletions.

[Jochen Becher]

This is tcpserver.cpp from manual tests which declares service before server. If I run it twice the second instance crashes on returning -1.

#include <QCoreApplication>

#include "qjsonrpctcpserver.h"
#include "testservice.h"

int main(int argc, char **argv)
{
    QCoreApplication app(argc, argv);
    TestService service;
    QJsonRpcTcpServer rpcServer;
    rpcServer.addService(&service);
    if (!rpcServer.listen(QHostAddress::LocalHost, 5555)) {
        qDebug() << "can't start tcp server: " << rpcServer.errorString();
        return -1;
    }

    return app.exec();
}

localserver.cpp has a similar problem.

[Matt Broadstone]

ah.. manual tests, yeah I don't automatically run those :) I'll take a look later today, thanks

[Matt Broadstone]

thanks for the heads up, fixed in https://bitbucket.org/devonit/qjsonrpc/commits/547875f75bd6b80e00171221fe3fab6d2691bc67