build error on Mac OS X

Matt Broadstone

Can you provide more information about your build setup, or about the actual error? OSX is my main development platform, so I'm surprised to see it not building for you on it.

2014-12-11T13:24:57+00:00

Victor Sklyar reporter

just compile qjsonrpc.pro under Mac OS X 10.10 Yosemite

Qt5.4, Desktop build

2014-12-11T13:32:32+00:00

Matt Broadstone

I literally just did, and it compiled just fine

2014-12-11T13:45:39+00:00

Victor Sklyar reporter

I just download sources from https://bitbucket.org/devonit/qjsonrpc/get/4240897c614b.zip And trying compile. Here what I see (http://dl2.joxi.net/drive/0000/0034/49186/141211/2395347b7b.png)

2014-12-11T13:55:01+00:00

Matt Broadstone

can you please try to compile from the command line and give me a full log of the attempts to compile? This looks very strange. I have 5.3.2 installed so there might be an issue with 5.4 on osx but it seems highly unlikely.

2014-12-11T14:00:39+00:00

Victor Sklyar reporter

machine isn't my and I can't :( sorry, but maybe you can install 5.4?

2014-12-11T14:02:18+00:00

Alex Skorodumov

Hi Matt,

I have tryied to compile QJsonRPC with Qt 5.4 today and also got errors. My errors was related to the difference in localy provided qjsonvalue.h header and official one. There are new classes (e.g. QJsonValueRefPtr) in the official version of qjsonvalue.h, which is missed in local veriosn of this file. And in some tests local file is included early then offical one. After removing include directive from failed cpp file the compilation became good, but I got strange behaviuor in run-time: notifications do not reach clients. I will try to dig more a bit later. Build with Qt 5.3.2 is Ok.

I am using MSVC2013.

May be this inforamation is related to Victor's case.

Regards.

2014-12-11T15:37:41+00:00

Matt Broadstone

hmm interesting, if we are using Qt >= 5.0 we should not be including the bundled json classes.. the problem would be here: https://bitbucket.org/devonit/qjsonrpc/src/4240897c614b332e107c90d01439f117ebf917a9/src/src.pro?at=master#cl-16

could you place this code:

message($$QT_MAJOR_VERSION)

within that lessThan check and see what your version is saying the major version is? Looks like we might have to make a special case for 5.4+

2014-12-11T16:24:30+00:00

Victor Sklyar reporter

I forget to say - I have success builds under ubuntu 14.10 x64 and win 8 x64 (qt 5.4)

2014-12-11T16:27:01+00:00

Matt Broadstone

This should be fixed with: 09b4ba8, sort of. It still seems that you guys in 5.4 are somehow linking in the included json classes, which is incorrect, so if one of you could do what I asked above and tell me what QT_MAJOR_VERSION is reporting as I'd appreciate it. It's unlikely I'll be updating to 5.4 even this week as I am swamped with work.

The changes included in the above commit should fix all the issues caused by the changes in the QJson classes in 5.4 though.