Memory leaks
Issue #20
resolved
Hi, I think that in QJsonRpcHttpReply::networkReplyFinished and in QJsonRpcHttpReply::networkReplyError you have a memory leaks.
Indeed, It seems to me that "reply" is never delete. You should add reply->deleteLater(); before Q_EMIT finished();
Comments (5)
-
-
- changed status to resolved
-
reporter Not sure that solved the problem. Indeed, this is ok when using the notify function because you don't wait a response. But when using sendMessage, the reply shoud be delete on networkReplyFinished or networkReplyError .
-
oh my bad, yeah looks like there is one in sendMessage. A normal QJsonRpcSocket uses notify internally to send the messages, not the case here.
-
- Log in to comment
https://bitbucket.org/devonit/qjsonrpc/src/b83726b8ce72a9d1a201cfeee80802c21734066e/src/qjsonrpchttpclient.cpp?at=master#cl-236