Split up source files
Issue #7
resolved
Could you please split up the source files into one file pair (.cpp/.h) per class?
E.g. I don't need the QJsonRpcTcpServer (I replace it by ZeroMQ), but it forces me to include QtNetwork.
Comments (4)
-
-
reporter Ok, I started working on that in my fork.
-
reporter If you submit a pull request to split these out, I'll approve :)
see pull request #18 :)
I hope this doesn't go too far.
-
- changed status to resolved
okay, I took in your first change but went a little bit of a different way after that :) please let me know if the current way things are split up are not sufficient for your requirements, I tried (and think I succeeded) in splitting them up so you can use relevant classes without a need to link to qtnetwork.
- Log in to comment
keeping everything together was ideal for easy inclusion into Qt at some point, but yes I see how it might be nice to split out the QJsonRpc*Server classes as it appears that there are a number of desired backends in the future (tcp/ssl, udp, zeromq?, http/https servers). If you submit a pull request to split these out, I'll approve :)