Code typo: allow(e)nce instead of allow(a)nce
Issue #616
resolved
>grep -R allowence src
src/libs/vpatterndb/vdetail.cpp: // seam allowence
src/libs/vlayout/vposter.h: quint32 allowence;
src/libs/vlayout/vlayoutdetail.cpp: qWarning()<<"Seam allowence is empty.";
src/libs/vlayout/vlayoutdetail.cpp: // seam allowence
src/libs/vlayout/vposter.cpp: :printer(printer), allowence(static_cast<quint32>(qRound(10./25.4*PrintDPI)))//1 cm
src/libs/vlayout/vposter.cpp: scissors->setPos(rec.x(), rec.y() + rec.height()-static_cast<int>(allowence));
src/libs/vlayout/vposter.cpp: line->setLine(rec.x() + rec.width()-static_cast<int>(allowence), rec.y(),
src/libs/vlayout/vposter.cpp: rec.x() + rec.width()-static_cast<int>(allowence), rec.y() + rec.height());
src/libs/vlayout/vposter.cpp: scissors->setPos(rec.x() + rec.width()-static_cast<int>(allowence), rec.y());
src/libs/vlayout/vposter.cpp: line->setLine(rec.x(), rec.y() + rec.height()-static_cast<int>(allowence),
src/libs/vlayout/vposter.cpp: rec.x() + rec.width(), rec.y() + rec.height()-static_cast<int>(allowence));
src/libs/vlayout/vposter.cpp: scissors->setPos(rec.x() + rec.width()-static_cast<int>(allowence),
src/libs/vlayout/vposter.cpp: rec.y() + rec.height()-static_cast<int>(allowence));
src/libs/vlayout/vposter.cpp: labels->setPos(rec.x() + layoutX, rec.y() + rec.height()-static_cast<int>(allowence)+layoutY);
src/libs/vlayout/vposter.cpp: labels->setTextWidth(rec.width()-(static_cast<int>(allowence)+layoutX));
src/libs/vlayout/vposter.cpp: const int pCount = qCeil(imgLength/pageLength);// Pages count without allowence (or allowence = 0) (3)
src/libs/vlayout/vposter.cpp: // Calculate how many pages will be after using allowence.
src/libs/vlayout/vposter.cpp: // each n-1 pages add (n-1)*allowence length to page (1).
src/libs/vlayout/vposter.cpp: const qreal addionalLength = (pCount-1)*static_cast<int>(allowence); //-V636
src/libs/vlayout/vposter.cpp: qCeil(addionalLength/pageLength)*static_cast<int>(allowence) + static_cast<int>(allowence) +
src/libs/vlayout/vposter.cpp: const int pCount = qCeil(imgLength/pageLength);// Pages count without allowence (or allowence = 0) (3)
src/libs/vlayout/vposter.cpp: // Calculate how many pages will be after using allowence.
src/libs/vlayout/vposter.cpp: // each n-1 pages add (n-1)*allowence length to page (1).
src/libs/vlayout/vposter.cpp: const qreal addionalLength = (pCount-1)*static_cast<int>(allowence); //-V636
src/libs/vlayout/vposter.cpp: return qCeil((addionalLength + qCeil(addionalLength/pageLength)*static_cast<int>(allowence) +
src/libs/vlayout/vposter.cpp: const int x = j*PageRect().width() - j*static_cast<int>(allowence);
src/libs/vlayout/vposter.cpp: const int y = i*PageRect().height() - i*static_cast<int>(allowence);
src/libs/vlayout/vlayoutdetail_p.h: /** @brief seamAllowence list of seam allowence points. */
src/libs/vlayout/vlayoutdetail_p.h: /** @brief layoutAllowence list of layout allowence points. */
src/libs/vlayout/vlayoutdetail_p.h: /** @brief layoutWidth value layout allowence width in pixels. */
src/libs/vtools/dialogs/tools/dialogdetail.cpp: // Default value for seam allowence is 1 cm. But pattern have different units, so just set 1 in dialog not enough.
Comments (8)
-
reporter -
repo owner Do you know how to make a pull request?
-
I put this on Your First Pull Request
http://yourfirstpr.github.io/
https://github.com/yourfirstpr/yourfirstpr.github.io/issues/73
Also sent out a tweet to beginner C++ programmers. -
repo owner Good idea.
-
- changed title to EASY Code typo: allow(e)nce instead of allow(a)nce
-
- changed title to Code typo: allow(e)nce instead of allow(a)nce
-
reporter I managed to do it https://bitbucket.org/dismine/valentina/pull-requests/153
-
repo owner - changed status to resolved
- Log in to comment
Also greed instead of grid