Automatically give workpiece details different names

Issue #791 duplicate
Julian Todd created an issue

By default if you don't go into the Labels section of each workpiece detail and edit the "Name of detail:" parameter, the output DXF-AAMA file is invalid.

This was confirmed downstream by this ticket when I was trying to work around it: https://github.com/mozman/dxfgrabber/issues/11

The current behavior assigns every workpiece detail with the name "Detail", which is a problem because this is the (should-be-unique) key that is used by the dxfentity INSERT to look up each dxfblock.

A simple fix would be to initialize these names to "Detail1", "Detail2", "Detail3", ...

Comments (3)

  1. Julian Todd reporter

    Many thanks for the fix.

    I didn't know anything about the fork when I posted the original duplicate to the other place; it's what the search engine took me to. There is no statement about the issue on either website to clear up any confusion for people who don't know; I eventually had to look for an article on a third site.

    On a technical matter, it might anyway be worth converting the repo from mercurial to git. I have a big mercurial project too (and I really hate git), but I'm coming to the realization that, like Betamax, we've simply lost the DVC war and it's not going to get any easier.

  2. Roman Telezhynskyi repo owner

    On a technical matter, it might anyway be worth converting the repo from mercurial to git. I have a big mercurial project too (and I really hate git), but I'm coming to the realization that, like Betamax, we've simply lost the DVC war and it's not going to get any easier.

    I agree with you, git is more popular than mercurial. But in the end they are simply tools. And when we are doing something we should think for what reason we do this change. There is no reason afraid that mercurial format cannot be converted to git in near future. Plus, yes, it is easy to convert even now, but i don't want. This will not bring more contributors or will make the project more popular. Pattern making is very rare interest among developers. The split happened to prove that i am wrong. There is no different which platform you are using Github or Bitbucket, or which DVC, git or mercurial if no one around to write a code. Unfortunately i don't see how i will benefit from using git. I believe that on my level there is no different between two. I still need something more for me to change my mind.

    And thank you for your request.

  3. Log in to comment