815b1cc·Author: Arthur Eigenbrot·Closed by: Arthur Eigenbrot·2022-03-24
Description
If the use_M12 fitting flag is set then it is expected that the Q_in parameter should be fixed at 0. This is because Q_in is a proxy for X12 in the parameterization of the M12 Mueller Matrix and so it doesn’t really make sense to use a fixed X12, but also fit Q_in.
This PR fixes a bug wherein Q_in was still allowed to be either fixed or free regardless of the setting on use_M12. Now if use_m12 is set then all options pertaining to Q_in are ignored and it is fixed to 0 during the fit.
If the
use_M12fitting flag is set then it is expected that the Q_in parameter should be fixed at 0. This is because Q_in is a proxy for X12 in the parameterization of the M12 Mueller Matrix and so it doesn’t really make sense to use a fixed X12, but also fit Q_in.This PR fixes a bug wherein Q_in was still allowed to be either fixed or free regardless of the setting on
use_M12. Now ifuse_m12is set then all options pertaining to Q_in are ignored and it is fixed to 0 during the fit.Â