Merged in dkist_spectral_lines (pull request #111)
Remove the incorrect determination of spectral line and replace it with the dkist-spectral-line library implementation.
dkist-spectral-line
Remove “spectral line” (actually filter) list and places it was used (parsing, Write_L1)
Write_L1
Populate @abstractmethod in the Write_L1 task to determine the wavelength range of a VISP frame
@abstractmethod
Update unit tests to ensure spectral line determination is working
For units, an example from VISP data we have currently has
CRVAL1 = 854.231 CDELT1 = 0.000999811469978602 CRPIX1 = -25.29957916079859 NAXIS1 = 2539
These values (specifically CRVAL and CDELT) imply units of nm.
CRVAL
CDELT
nm
Remove the incorrect determination of spectral line and replace it with the
dkist-spectral-linelibrary implementation.Remove “spectral line” (actually filter) list and places it was used (parsing,
Write_L1)Populate
@abstractmethodin theWrite_L1task to determine the wavelength range of a VISP frameUpdate unit tests to ensure spectral line determination is working
For units, an example from VISP data we have currently has
CRVAL1 = 854.231 CDELT1 = 0.000999811469978602 CRPIX1 = -25.29957916079859 NAXIS1 = 2539These values (specifically
CRVALandCDELT) imply units ofnm.