Don't create a new manager on each request

Issue #1 resolved
Konstantine Rybnikov
created an issue

Our servers had error spike, due to which they tried to send many errors via raven, but this brought them quicly to eat more and more RAM which wasn't freed. I'm not 100% sure what happened, but one mis-behavior which seems clear is that this raven client is creating a new manager on each operation (0), which is quite a heavy operation.

This mis-behavior is not easy to spot. I propose that you require a manager to be passed upon initialization to ensure this doesn't bring problem for other users.

Thank you!

(0): http://hackage.haskell.org/package/raven-haskell-0.1.0.1/docs/src/System-Log-Raven-Transport-HttpConduit.html#sendRecord

Comments (3)

  1. Log in to comment