Module description box has oddly sized, changing horizontal scrollbar

Issue #5 closed
Lewis Rosenthal created an issue

Some modules do not need a scrollbar at all (Cairo Clock), while others could do with some judicious line wrapping (ArcaOS Logo). In fact, if lines wrapped properly, there should be no need of a horizontal scrollbar at all, unless the properties notebook were really squeezed. If the text cannot flow, suggest inserting some line breaks (I recall the line break discussion last month on the os2-dev list, but I think this box should be different).

Comments (12)

  1. Dave Yeo repo owner

    I can remove the horizontal scrollbar by removing the MLS_HSCROLL statement at line 177 in WPSDesktop\WPSDesktop-Resources.Rc but then every description will need newlines added in the correct place, which takes some experimentation to look good and would be really hard for the Chinese which only displays as garbage here and Russian which is not much better. Better would be if the scrollbar acted like the vertical scrollbar, not sure why it is greyed out when unneeded while the horizontal one is always active. Having the text reflow would be ideal. No idea how to do that.

  2. Lewis Rosenthal reporter

    I wonder if the WPSTK might have any useful code for this? I just took a brief read the through the docs for it, and didn;t come up with anything which seemed pertinent (not sure how one would go about bolting any of that onto an existing project, if not starting with it from the ground up).

  3. Dave Yeo repo owner

    This was actually easy, download and use the Universal Resource Editor, lots of learning with that, the default font (if no language files) reverted from system proportional to Helvetica. We override anyways so doesn’t matter much. Perhaps an extra linebreak could be added before “Written by”… ?

  4. Lewis Rosenthal reporter

    Yes, the vertical space is there, so an extra line between paragraphs would be nice.

  5. Dave Yeo repo owner

    Decided to not add the extra newline for now and committed my changes. New test build at test.

  6. Lewis Rosenthal reporter

    Yes, this is fine. The only caveat is that some modules (e.g., Slide Show) have manual breaks (\n) in the description which now conflict with the wrapping:

    \nThis module uses the GBM library with JPEG support\nand is based in part on the work of the Independent\nJPEG Group.";

    So we get things like:

    I realize that culling all of the unwanted breaks is a pain, so I wouldn't suggest this without offering to do some of the work. It’s also trivial, so surely not a blocker to the next release.

  7. Dave Yeo repo owner

    I fixed the extra linebreaks in the slideshow and show image modules. Luckily (unluckily?) they don’t have as many translations. The rest seem OK.

  8. Log in to comment