1. Augie Fackler
  2. hgit
  3. Pull requests

Pull requests

#1 Declined
Repository
andrew_shadura
Branch
default
Repository
durin42
Branch
default

Update hgit to the latest Mercurial

Author
  1. Andrew Shadura
Reviewers
Description

Now it works with hg 2.4

Comments (5)

  1. Augie Fackler repo owner

    I've gotten things "working" with hg 2.5 - supporting 2.4 isn't really something I'm interested in. Note that the testsuite is still a bit of a basketcase - feel encouraged to look into running the tests to see if you can make it work if you're interested. I'm only somewhat interested in hgit at the moment.

    1. Andrew Shadura author

      Well, now it works with 2.4 as well; it seems like I did some things not really right — not surprising considering my low level of knowledge of Mercurial internals :)

      I wonder, however, why wasn't that n = self.node(n) wasn't needed.

  2. Augie Fackler repo owner

    I'm actually actively disinterested in supporting 2.4 - it adds a little code complexity and maintenance burden for something that I don't even really consider reliable anyway. hgit is still a horrifying hack. Run the tests if you don't believe me (they used to all pass).

    1. Andrew Shadura author

      Probably you've misunderstood me. I've tried your code and it works fine in 2.4 with no further modifications. Which makes me wonder why that second change to gitlog.py wasn't needed — I can't figure it out myself.