Issue #14 resolved

Make it possible to import history starting at some revision

Augie Fackler
repo owner created an issue

Right now, if you don't import the complete history of a project, replay fails in exciting ways. It's blocked from actually going through as a result to protect the user.

It should be possible to detect where the diff application will fail and perform extra full-text requests as needed.

Comments (9)

  1. Dan Villiom Podlaski Christiansen

    It should be possible to detect where the diff application will fail and perform extra full-text requests as needed.

    I don't believe we have to implement that. As far as I can tell, filling in the low water mark to the replay function should suffice. Currently, this is taken from the oldest_rev_i_have argument to the get_replay function; it's never filled in, so it will always defaults to zero.

  2. Dan Villiom Podlaski Christiansen

    @parren : Thanks for reminding me about this bug; I had completely forgotten we had it in on file!

    I don't believe we have to implement [such detection]. As far as I can tell, filling in the low water mark to the replay function should suffice. Currently, this is taken from the oldest_rev_i_have argument to the get_replay function; it's never filled in, so it will always defaults to zero.

    I was wrong; we did have to fetch the full text of the first revision. For this reason, support for starting at a non-zero revision is restricted to single directory clones. I'm marking this bug as resolved, anyway; at least there's a way to do it now, even if it isn't entirely perfect.

  3. Log in to comment