Issue #288 open

Support for --style in incoming command broken?

Andrey Loskutov
created an issue

Hi,

I've used hgsubversion successfully few month ago with MercurialEclipse plugin and I'm not sure but I think I was able to use "--style" in incoming command, so that I saw "incoming" changesets in the synchronize view.

Right now I only see that "hg out --style ..." works fine, but "hg in --style..." simply prints out the default, not formatted output.

Especially we use those styles for incoming/outgoing commands:

http://code.google.com/a/eclipselabs.org/p/mercurialeclipse/source/browse/#hg%2Fplugin%2Fstyles

Is it a regression, or was it never working?

hg --version Mercurial Distributed SCM (version 1.8.4)

hgsubversion used is the latest head (from 15.06.2001).

I appreciate your extension, many thanks for doing this job.

Regards, Andrey

Comments (1)

  1. Dan Villiom Podlaski Christiansen

    I'm fairly certain hgsubversion always displayed incoming revisions like that. As a result, I'm lowering the severity of this issue to »proposal«.

    Now, on to why we do it like that: The Mercurial display logic works on changesets, or as they're known in the source code, contexts. When showing outgoing changes, the contexts are readily available in the repository, so we just display those. For incoming, however, we aren't so lucky, so we roll our own displayer. It's not terribly graceful, but it at least it works. FWIW regular incoming relies on the fact that it's fairly easy to get the changeset data over the wire.

    I once tried to create mock changesets and hook them up with the displayer, but I couldn't get it to work. An alternative approach would be to invoke the templater directly, passing it the relevant variables from the Subversion log output. If you're interested in fixing this, I'd suggest trying that approach.

  2. Log in to comment