clone fails on z3c.blobfile (patch)

Create issue
Issue #156 resolved
Gerhard Weis created an issue

hg clone svn+ fails.

The problem is in where the root-folder name is stripped off twice form missing file names.

attached patch fixes it.

I am not sure how to add a test for this.


Comments (9)

  1. Augie Fackler repo owner

    Hm, I can't download the attachment because of what appears to be a bitbucket bug. Contacting Jesper.

  2. Augie Fackler repo owner
    • changed status to open

    Reopening because that patch breaks tests.

    Honestly, I'm not sure what the right fix is, since I've seen reports that jive with yours, but I'm also seeing your tests break a handful of tests.

  3. Gerhard Weis reporter

    Interesting that it breaks other tests. Just reasoning from the code, it should definitely not remove the root-prefix twice. (At least I could not think of a case where this might be useful, except, there is somewhere else a problem which prepends the root twice..)

    I'am not sure when I'll find time, but I guess the only way is to debug failing tests with the patch applied.

  4. Gerhard Weis reporter

    Ok. I did the same change at the only other place in the code and the test suite runs fine on my system. (and cloning of the svn-repo in question works too.)

    New patch is attached.

  5. Log in to comment