1. Augie Fackler
  2. hgsubversion
Issue #156 resolved

clone fails on z3c.blobfile (patch)

gweis
created an issue

hg clone svn+http://svn.zope.org/repos/main/z3c.blobfile fails.

The problem is in editor.py where the root-folder name is stripped off twice form missing file names.

attached patch fixes it.

I am not sure how to add a test for this.

cheers

Comments (9)

  1. Augie Fackler repo owner
    • changed status to open

    Reopening because that patch breaks tests.

    Honestly, I'm not sure what the right fix is, since I've seen reports that jive with yours, but I'm also seeing your tests break a handful of tests.

  2. gweis reporter

    Interesting that it breaks other tests. Just reasoning from the code, it should definitely not remove the root-prefix twice. (At least I could not think of a case where this might be useful, except, there is somewhere else a problem which prepends the root twice..)

    I'am not sure when I'll find time, but I guess the only way is to debug failing tests with the patch applied.

  3. Log in to comment