1. Augie Fackler
  2. hgsubversion
  3. Issues
Issue #43 resolved

Unit tests fail on Windows

Anonymous created an issue

Windows XP, hg 1.1.1, hgsubversion 463998d266e3,svn-win32-1.5.4_py25

I get the attached error messages when running the hgsubversion tests (python tests\run.py). I didn't check what causes the first one, but the rest seem to happen because file URL changes.

First, colon (:) gets converted to %3A which Firefox accepts, but the Windows Run dialog doesn't. Second, slashes get converted to backslashes which get represented as %5C, which is fine both for Firefox and Run dialog. Finally, one slash from the start of the URL gets dropped off and this is definitely wrong.

So it seems that the test case is a bit too restrictive, but there is also some funky file URL translation going on somewhere.

I can't vouch who's to blame here.

Despite these errors I could successfully clone the nose repo.

Comments (5)

  1. Anonymous

    Thanks for your quick response. I updated hgsubversion and applied the patch and now the tests pass OK.

    I still get an error in test_push_command.PushOverSvnserveTests, but I guess it's caused by the local firewall. Previously I wasn't around to click Allow to the connection attempt, so it apparently timed out. Now I clicked Alllow, but still got:

      SubversionException: ("Can't connect to host 'localhost': No connection could be
       made because the target machine actively refused it.  ", 730061)
    

    Case closed as far as I'm concerned.

    risto.kankkunen(a)iki.fi

  2. Patrick Mézard

    Yes, the svn serve test is a bit unreliable because of network effects or because os.kill does not exist under Windows. It's not critical for now, IMHO.

    The issue can be closed when durin42 actually pushes the fix here.

  3. Log in to comment