1. Augie Fackler
  2. hgsubversion

Pull requests

#24 Declined
Repository
willthames
Branch
missing_deque
Repository
durin42
Branch
default

Fix for missing mercurial.utils deque

Author
  1. willthames
Reviewers
Description

mercurial.utils does not always contain deque (e.g. it doesn't in mercurial-2.2.3-1.fc17.x86_64 rpm) Respecting recent commit that uses mercurial.utils for python 2.4 we try default collections deque and fallback to mercurial.utils deque

  • Learn about pull requests

Comments (3)

  1. Greg Ward

    Your patch is invalid; it contains conflict markers. You should probably close it and try again. Hint: run the tests before committing (just run nosetests from the hgsubversion root dir).

  2. Greg Ward

    Oops, I misunderstood. I think the conflict markers just mean that this fix has already been applied, independently of your pull request. So this pull request is no longer needed; you might as well close it.

  3. willthames author

    Yeah, you're right - I submitted this, then realised that patches should be sent through the mailing list, and submitted this by email. And promptly forgot about this PR. I'll close it now.