Commits

Anonymous committed 92dc2aa

Added another TODO note about generate_field_definition needing to support model inheritance

Comments (0)

Files changed (1)

management/commands/startmigration.py

             field_pieces.append(match.groups()[0])
             if test_field(' '.join(field_pieces)):
                 return ' '.join(field_pieces)
-                
+    
+    # TODO:
+    # If field definition isn't found, try looking in models parents.
+    # This should most likely work with just a recursive call to generate_field_definition
+    # supplying the models parents and the current field
+    
     # the 'id' field never gets defined, so return what django does by default
     # django.db.models.options::_prepare
-    if field.name == 'id' and isinstance(field, models.AutoField):
+    if field.name == 'id' and field.__class__ == models.AutoField:
         return "models.AutoField(verbose_name='ID', primary_key=True, auto_created=True)"
             
     raise Exception("Couldn't find field definition for field: '%s' on model: '%s'" % (
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.