Tiles format does not support multilang filter in course topic names
Hi David,
when using the plugin https://moodle.org/plugins/filter_multilang2 , and I use the filter in the title of a course section, then the tile format does not apply the filter. Instead the markup is displayed. See screenshot:
I will try so solve that issue and hopefully you accept my pull request.
Kind regards,
David
Comments (7)
-
reporter -
repo owner Thanks David it’s a good call and I am happy to merge it.
Actually I think I should probably change the line 238 to this, to take advantage of the existing method and for consistency with line 314. Can you verify that this would fix your issue?
$data['title'] = get_section_name($this->course, $this->sectionnum);
-
reporter Hi David,
thank you for your feedback and the code proposal. In fact the above line always displays the general section of the course. But this line works:
$data['title'] = get_section_name($this->course, $thissection);
Kind regards,
David
-
reporter … maybe passing on
$section
instead of $sectionid on line 314 improves performance a little bit (but as it should be cached anyway)Kind regards,
David
-
repo owner Thanks David. I am working on some new features in a private branch at present, but have included it there. It should be released later this month. (It has slightly different instance variables which explains our discrepancy above - my apologies for that).
-
reporter Thank you for this great course format. I am looking forward to your next release.
-
repo owner - changed status to resolved
Fixed in version 3.7.0 beta
- Log in to comment
Hi,
I solved the problem and would be happy if you can merge (Can not create a pull request here):
https://bitbucket.org/dasistwas/moodle-format_tiles/src/master/
https://bitbucket.org/dasistwas/moodle-format_tiles/commits/49d2ee69f03a9207e88ec4f0a6d02559285ee374
Kind regards,
David