upgrade path error

Hello everyone,
While doing the upgrade for tiles format in 4.3, i got the following error in our CI/CD pipelines:

format_tiles_tile_options
* column 'optiontype' should be NOT NULL (I)
* column 'elementid' should be NOT NULL (I)

This caused by discrepancy in the upgrade, while the course/format/tiles/db/install.xml says NOTNULL="true" for the optiontype and elementid fields, the course/format/tiles/db/upgrade.php doesn’t reflect this behavior, so i made a patch adding XMLDB_NOTNULL as follows:

// Open LMS patch: fix upgrade path using XMLDB_NOTNULL instead of 'null'.
$table->add_field('optiontype', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, null, null);
$table->add_field('elementid', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, null, null);
// Open LMS patch end.

This intended to fix the upgrade path build.

Can those database fields have NULL value, if not, can you add this change to the repository?

Comments (2)