new unit test failures in 3.9 and higher

[Dan Marsden]

The unit test get_course_get_enrolled_courses_for_logged_in_user_test_cases is now failing in 3.9 and some other branches due to changes that landed in core this week.

I’m not even sure what it’s really testing related to the tiles format? - seems to be checking how many db queries that Moodle Core functions seem to be doing - I suspect this should just be removed from the codebase?

‌

[Dan Marsden]

looks like it’s an accidental direct copy/paste of some core tests from course/tests/externallib_test.php so they should definitely be removed!

[Dan Marsden]

looks like a lot of those tests in that file should be removed - some are testing forum activity, others are not touching tiles at all..

[David Watson]

You are right Dan they were copied in bulk a while ago. I will review and remove as necessary

[David Watson]

Tests removed in commit 351984e