Wrong revision set as "good" rom when using 1G1R option - no intro

Issue #106 resolved
RedSnake
created an issue

Hi,

When a no-intro game has 2 revisions (or more), sometimes ROMCenter sets the older revision as the good one, which is incorrect.

Example from "Nintendo - Game Boy Advance.dat":

<game name="Advance Wars (Europe) (En,Fr,De,Es)">
    <description>Advance Wars (Europe) (En,Fr,De,Es)</description>
    <release name="Advance Wars (Europe) (En,Fr,De,Es)" region="EUR"/>
    <rom name="Advance Wars (Europe) (En,Fr,De,Es).gba" size="8388608" crc="66fb29e9" md5="f4c2b2fda444dcec1274844b9a764d64" sha1="d5f06a82c3e5f963ef169763edc2d691fed8124e" status="verified"/>
</game>
<game name="Advance Wars (USA)" cloneof="Advance Wars (Europe) (En,Fr,De,Es)">
    <description>Advance Wars (USA)</description>
    <rom name="Advance Wars (USA).gba" size="4194304" crc="dbef116c" md5="27f322f5cd535297ab21bc4a41cbfc12" sha1="d0a0a4cfe9b95ac7118f7ef476f014ca0242eb65" status="verified"/>
</game>
<game name="Advance Wars (USA) (Rev 1)" cloneof="Advance Wars (Europe) (En,Fr,De,Es)">
    <description>Advance Wars (USA) (Rev 1)</description>
    <release name="Advance Wars (USA) (Rev 1)" region="USA"/>
    <rom name="Advance Wars (USA) (Rev 1).gba" size="4194304" crc="26fd0fc9" md5="04775a93461d24cf1a7e3346d244e516" sha1="15053499d5b3f49128a941d7f2d84876f5424d0c" status="verified"/>
</game>
<game name="Advance Wars (USA) (Wii U Virtual Console)" cloneof="Advance Wars (Europe) (En,Fr,De,Es)">
    <description>Advance Wars (USA) (Wii U Virtual Console)</description>
    <rom name="Advance Wars (USA) (Wii U Virtual Console).gba" size="4194304" crc="bde36f98" md5="0cf8afe8006793c1c96ade67e872ce84" sha1="44551654068eac31e29de2f8d78059a1b1f14347" status="verified"/>
</game>
<game name="Advance Wars (Europe) (En,Fr,De,Es) (Virtual Console)" cloneof="Advance Wars (Europe) (En,Fr,De,Es)">
    <description>Advance Wars (Europe) (En,Fr,De,Es) (Virtual Console)</description>
    <rom name="Advance Wars (Europe) (En,Fr,De,Es) (Virtual Console).gba" size="8388608" crc="8400759c" md5="c3f79dd7eb12b961f5bdd00c05eb37a7" sha1="5ab62a81e34c5786e879446bd4dea5ca071eb94b" status="verified"/>
</game>

In this case when I set region priority to USA, then EUR, I should get Advance Wars (USA) (Rev 1) as the good rom to possess.

But ROMCenter tags it as unknwown and wants Advance Wars (USA) and tags it as missing.

The problem probably comes from the purposely missing <release name="Advance Wars (USA)" region="USA"/> node.

I don't know the exact rules of writing dat files used by no-intro, but games with missing <release/> node shouldn't be processed.

Please note that precisely concerning this game, a fix was added on the no-intro dat and can be found on their discusion threads on gba.dat:

*2018-06-12 21:37:58 (replies: 1) Region issue

"Advance Wars (USA)" - Has USA region assigned to it, but needs it removed so that Rev 1 (0290) can be the 1G1R if Rev 1 is the most current".*

And their fix consisted in removing the <release/> node.

This problems exists for severall roms and systems.

Regards.

Comments (2)

  1. Log in to comment