Issue #264 resolved
shibe created an issue

I’m running ECWolf 1.3.3 on Wayland. For that, I compile it with GTK 3 and SDL 2.

Would you accept a patch for GTK 3 support?

Should compatibility with GTK 2 be retained?

I think, at this point GTK 2 is just for legacy software.

Comments (5)

  1. Braden Obrzut

    I actually already have the GTK3 code in ZDoom. Just haven’t pulled it in yet since IIRC I made that code depend on C++11.

  2. shibe reporter

    So what is your plan? Move to C++11 or just change GTK 2 to GTK 3? In the latter case the required changes are few.

  3. Braden Obrzut

    My plan two years ago was to move to C++11 with ECWolf 1.5 and then I would pull in the code. The C++11 requirement comes from the dynamic loading code which allowed both GTK2 and GTK3 to be supported by the same code as well as removing the hard dependency on GTK because as a KDE user I have no need for it (ECWolf uses kdialog under KDE).

  4. Braden Obrzut

    Just did a survey of the distros I care about and it looks like they all have GTK3 these days (probably obvious, but I know when I added GTK3 support to ZDoom this was not the case) so yeah feel free to submit a GTK3 only patch if you want to accelerate the migration. I do eventually want to pull in my code that makes GTK only loaded when needed, but that can wait for 1.5 per my original plans.

  5. Log in to comment