Add UTF-8 support

sorcerer avatarsorcerer created an issue

When patch contains non-ASCII UTF-8 characters, crecord incorrectly displays them. Also, scrolling doesn't work well (bottom lines aren't displayed). I can make an example if needed.

Comments (7)

  1. edgimar

    Please do add a test-case, so that if needed, we can test for this in the future -- preferably in the form of a shell-script which (1) creates the files and directories needed, and (2) calls the necessary hg commands on these files/directories.

  2. sorcerer

    Please sorry for so long delay.

    I've attached two text files:

    • file2 which contains of repeated single word in russian
    • file2.patch, a patch to it

    Please create a repository with file2 as initial revision, then apply the patch and try to crecord it. I see many incorrect characters and only 3 of 5 changed lines. hg diff shows changes correctly.

  3. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.