AttributeError: 'localrepository' object has no attribute 'join'

#14 Merged at c933cc1
Repository
crecord-wjoin
Branch
default
Repository
crecord
Branch
default
Author
  1. cheater00
Reviewers
Description

This fork fixes this issue that started cropping up after I upgraded hg from 2.4.2 to 4.4.1.

Comments (4)

  1. MBSolutions

    +1, fixed the same issue for me:

    Unknown exception encountered with possibly-broken third-party extension crecord which supports versions 3.6 of Mercurial. Please disable crecord and try your action again. If that fixes the bug please report it to https://bitbucket.org/edgimar/crecord/issues Python 2.7.14+ (default, Feb 6 2018, 19:12:18) [GCC 7.3.0] Mercurial Distributed SCM (version 4.4.1) Extensions loaded: fetch, gpg, graphlog, hgk, highlight, strip, mq, pager, purge, rebase, transplant, patchbomb, extdiff, crecord, hgnested, hggit Traceback (most recent call last): File "/usr/bin/hg", line 41, in <module> dispatch.run() File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 85, in run status = (dispatch(req) or 0) & 255 File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 173, in dispatch ret = _runcatch(req) File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 313, in _runcatch return _callcatch(ui, _runcatchfunc) File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 321, in _callcatch return scmutil.callcatch(ui, func) File "/usr/lib/python2.7/dist-packages/mercurial/scmutil.py", line 154, in callcatch return func() File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 303, in _runcatchfunc return _dispatch(req) File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 940, in _dispatch cmdpats, cmdoptions) File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 701, in runcommand ret = _runcommand(ui, options, cmd, d) File "/usr/lib/python2.7/dist-packages/hgext/pager.py", line 77, in pagecmd return orig(ui, options, cmd, cmdfunc) File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 948, in _runcommand return cmdfunc() File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 937, in <lambda> d = lambda: util.checksignature(func)(ui, *args, strcmdopt) File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1185, in check return func(args, kwargs) File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1185, in check return func(*args, kwargs) File "/usr/lib/python2.7/dist-packages/hgext/mq.py", line 3583, in mqcommand return orig(ui, repo, args, kwargs) File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1185, in check return func(*args, kwargs) File "/home/mathiasb/bin/python/crecord/crecord/init.py", line 36, in crecord dorecord(ui, repo, commands.commit, pats, *opts) File "/home/mathiasb/bin/python/crecord/crecord/crecord_core.py", line 199, in dorecord return cmdutil.commit(ui, repo, recordfunc, pats, opts) File "/usr/lib/python2.7/dist-packages/mercurial/cmdutil.py", line 3090, in commit return commitfunc(ui, repo, message, matcher, opts) File "/home/mathiasb/bin/python/crecord/crecord/crecord_core.py", line 91, in recordfunc backupdir = repo.join('record-backups') File "/usr/lib/python2.7/dist-packages/mercurial/repoview.py", line 236, in getattr return getattr(self._unfilteredrepo, attr) AttributeError: 'hgrepo' object has no attribute 'join'

  2. Mark Edgington repo owner

    I'll merge this PR, but you should be aware that crecord is now built-in to mercurial, and you don't need to use a separate extension with current versions of mercurial. See the --interactive flag for hg commands like commit.

  3. cheater00 author

    Hey Mark, hg ci --interactive is no replacement for crecord! Even though git has had that sort of interface since forever, crecord is so much better in the UX department that it's the single thing that kept me using hg all these years. In fact I only started seriously using git after discovering git gui exposes a visual interface similar to crecord (now I use vimagit). Still neither are as good as crecord. If people are considering abandoning crecord, who do I talk to so this can be reconsidered?