Pull requests

#6 Merged
Repository
immerrr
Branch
default
Repository
edgimar
Branch
default

Allow amending without changes

Author
  1. immerrr
Reviewers
Description

Should fix issue #43.

I'm not sure about side effects of these changes, the rest of recordfunc is kind of hard to follow and I'm not sure if such a small change warrants a refactoring the code around it.

Comments (2)

  1. edgimar repo owner

    At first this looked fine, so I merged it, but I've changed my mind. It causes a traceback when using amend when there are no changes in the working directory. And, it really doesn't work -- if you try to only change the commit message, and deselect everything for commit, then all changes in the working dir are committed. It is also technically not necessary, since you can change a commit's comments with 'hg ci -X . --amend'. So, I'm going to backout the change.

  2. immerrr author

    Would be nice to have a comment that not newfiles will commit everything, that was rather unexpected.

    Technically, it's rather hg ci -X $(hg root) --amend, but yeah, it can be made an alias.