[FixInsight Warning] dwsClasses.pas(322): W503 Assignment right hand side is equal to its left hand side

[IlyaS]

dwsClasses.pas Line 322: W503 Assignment right hand side is equal to its left hand side

function TdwsStrings.GetCommaText: UnicodeString;
var
  FOldDefined: TStringsDefined;
  FOldDelimiter: Char;
  FOldQuoteChar: Char;
begin
  FOldDefined := FDefined;
  FOldDelimiter := FDelimiter;
  FOldQuoteChar := FQuoteChar;
  Delimiter := ',';
  QuoteChar := '"';
  try
    Result := GetDelimitedText;
  finally
    FDelimiter := FOldDelimiter;
    FQuoteChar := FOldQuoteChar;
    FDefined := FDefined; //Assignment right hand side is equal to its left hand side
  end;
end;

meant to be?

FDefined := FOldDefined;

[Eric Grange]

Fixed Issue #59

→ <<cset eb26bbad769d>>

[Eric Grange]

Indeed. Though this unit is essentially obsolete / deprecated (hence the prehistoric source code style)