Text-based DenseBase input

#73 Open
Repository
jdh8
Branch
default
Repository
eigen
Branch
default

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r efac0f0a667e https://bitbucket.org/jdh8/eigen
hg merge efac0f0a667e
hg commit -m 'Merged in jdh8/eigen (pull request #73)'
Author
  1. Chen-Pang He
Reviewers
Description

New feature

  • Text-based DenseBase input

Bugfix

  • Forward declare SparseMatrix to let KroneckerProduct compile

Comments (3)

  1. Christoph Hertzberg

    We have Bug 622, for this feature request. I made some comments on your patch (and the feature request in general) there.

    1. Chen-Pang He author

      Thanks for informing me about this bug. I'm inspired by mailing list instead of bugzilla.

  2. Chen-Pang He author

    Why not accept the change on unsupported/Eigen/KroneckerProduct? It is unrelated to text IO dispute, and it is critical for the code below to compile.

    #include <unsupported/Eigen/KroneckerProduct>
    #include <iostream>
    
    int main ()
    {
        using namespace Eigen;
        using namespace std;
    
        srand(time(NULL));
        cout << kroneckerProduct(MatrixXd::Random(4,3), MatrixXd::Random(2,1)) << endl;
    
        return 0;
    }