Distinguish between local and global reduction handles

[Erik Schnetter]

Local and global reduction handles both use small integers. This means that code may accidentally confuse one for the other.

To avoid this, we could add large, different offsets for local and global handles, so that they would be different. We already do this for other integer IDs in the flesh.

Keyword:

[Roland Haas]

Local and global here refer to the handles returned by

int CCTK_ReductionHandle(const char *reduction_name);
int CCTK_ReductionArrayHandle(const char *reduction_name);  

respectively.

[Roland Haas]

Pull request is here: https://bitbucket.org/cactuscode/cactus/pull-requests/107/cactus-use-different-handle-ranges-for-old

[Roland Haas]

Please review.

[Roland Haas]

Of note: CarpetReduce is one of the codes that confuses them, so this is by no means unlikely to happen . Fixed in rhaas/reductionhandles of CarpetReduce.

There’ may be more thorns doing the same (often using CCTK_ReduceLocalScalar) leading to failed tests.

[Roland Haas]

Also affected are: cactusnumerical, cactusutils, einsteinanalysis, pittnullcode