Issue #1001
open
Local and global reduction handles both use small integers. This means that code may accidentally confuse one for the other.
To avoid this, we could add large, different offsets for local and global handles, so that they would be different. We already do this for other integer IDs in the flesh.
Keyword:
Comments (6)
-
-
- edited description
- changed status to open
-
-
Please review.
-
Of note: CarpetReduce is one of the codes that confuses them, so this is by no means unlikely to happen
. Fixed in rhaas/reductionhandles of CarpetReduce.
There’ may be more thorns doing the same (often using
CCTK_ReduceLocalScalar
) leading to failed tests. -
Also affected are: cactusnumerical, cactusutils, einsteinanalysis, pittnullcode
- Log in to comment
Local and global here refer to the handles returned by
respectively.