- changed status to open
- removed comment
do not re-parse file when using open_one_input_file_at_a_time
this patch retains the patch map created when reading a file even when the file itself is closed due to open_one_input_file_at_a_time. Since parsing the file is slow this can considerably speed up open_one_input_file_at_a_time.
Keyword:
Comments (7)
-
reporter -
- removed comment
Please apply.
Does the other patch (that clears the list of patches) also have bits that need to be applied, e.g. closing HDF5 properties?
-
reporter - removed comment
yes
#1027should also be applied.#1027is a bugfix only patch. That means that something gets added and removed right away. The bugfix patch looked incomplete otherwise. I did not want to make this patch part of bugfix patch (to separate new features from bugfixes).- 1027 contains two necessary fixes: free()ing the filename and closing the HDF5 xfer property. The asserts are optional, the patches.clear() is reverted by this patch.
-
- removed comment
In this case, please apply both.
-
- changed status to open
- removed comment
-
reporter - changed status to resolved
- removed comment
applied as carpet hash 1089cd7c139d "CarpetIOHDF5: do not re-parse files for patches when using"
-
reporter - edited description
- changed status to closed
- Log in to comment