do not re-parse file when using open_one_input_file_at_a_time

Create issue
Issue #1028 closed
Roland Haas created an issue

this patch retains the patch map created when reading a file even when the file itself is closed due to open_one_input_file_at_a_time. Since parsing the file is slow this can considerably speed up open_one_input_file_at_a_time.


Comments (7)

  1. Erik Schnetter
    • removed comment

    Please apply.

    Does the other patch (that clears the list of patches) also have bits that need to be applied, e.g. closing HDF5 properties?

  2. Roland Haas reporter
    • removed comment

    yes #1027 should also be applied. #1027 is a bugfix only patch. That means that something gets added and removed right away. The bugfix patch looked incomplete otherwise. I did not want to make this patch part of bugfix patch (to separate new features from bugfixes).

    1. 1027 contains two necessary fixes: free()ing the filename and closing the HDF5 xfer property. The asserts are optional, the patches.clear() is reverted by this patch.
  3. Log in to comment