CarpetLib::interpolate_from_buffer_zones should by default set to "no"

Create issue
Issue #1099 closed
Frank Löffler created an issue

CarpetLib::interpolate_from_buffer_zones should by default set to "no" after it is properly tested and we should think about whether we have a good reason to not remove that paramter then again. Adding the release tag because we don't want to have a change like this affecting two releases.


Comments (10)

  1. Ian Hinder
    • removed comment

    We probably don't want to change numerical results just before a release. I don't understand Frank's comments about affecting two releases; what did you mean Frank? I propose that we change the default after the upcoming release, when we can test it properly. We should keep the parameter so that people can check that their numerical results have changed only as a result of this change. After the next release, we can drop the parameter.

  2. Frank Löffler reporter
    • removed comment

    We would now add a note to the release notes that this parameter should be set to "no" to have proper behavior (but this is apparently not well tested yet), in a later release the default might change, in a later release we would deprecate that parameter and at a yet late release we would remove it again.

  3. Log in to comment