Thorn configuration scripts should not be run if there are missing thorns

Create issue
Issue #1252 closed
Ian Hinder created an issue

If there are thorns present in the thornlist which are not present in the source tree, Cactus currently displays the corresponding error message, and then runs the rest of the CST including thorn configuration scripts. Since these can build large external libraries (e.g. LORENE), it can be a long time before the user notices that the build has failed. I would prefer if Cactus aborted before running the CST scripts.

Keyword: postrelease

Comments (17)

  1. Roland Haas
    • removed comment

    Erik is working on making the ExternalLibraries build themselves at the same time as the other thorns in ticket 1707 which is also up for review (the branch seems to have stabilized, at least there were no changes over the weekend).

    Are those two approaches both applicable (ie does this patch still make sense assuming that all ExternelLibraries would soon do what GSL is trying to do in Erik's branch)?

  2. Frank Löffler
    • removed comment

    Assuming all external libraries are changed (even outside the ET) I don't see the immediate need for this change anymore, true. The only harm I can see, on the other hand, is that Cactus would bail out before it detected all possible errors - but then if it already got errors in that stage, the likelihood that following errors are simply caused by the earlier ones is high.

  3. Roland Haas
    • removed comment

    Can this be closed (see comment:6) due to the changes to ExternalLibraries separationg detection from building?

  4. Frank Löffler
    • removed comment

    Yes. Just for the record: the CST aborts early in this case now. I just couldn't find this ticket when I merged the pull request a while back.

  5. Log in to comment